add How to Add Dashboards for EnvoyGateway#758
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a documentation guide that supplies two MonitorDashboard manifests (control-plane and data-plane), two Prometheus PodMonitor resources for scraping metrics, and operational instructions to apply, verify, and roll back the combined manifest. ChangesEnvoyGateway Monitoring Dashboard Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/en/solutions/How_to_add_Dashboard_for_EnvoyGateway.md`:
- Around line 33-35: Update the prerequisites to include RBAC for PodMonitor: in
addition to requiring permission to create MonitorDashboard in the cpaas-system
namespace, explicitly require permission to create PodMonitor resources in
cpaas-system (and note that the monitoring stack must support PodMonitor).
Reference the resource names MonitorDashboard and PodMonitor and the namespace
cpaas-system so the manifest creators know to add/create the PodMonitor RBAC
rule.
- Around line 223-230: The latency panels use PromQL like
histogram_quantile(..., rate(status_update_duration_seconds_bucket{...}[2m]))
but the Grafana panel unit is set to ms, causing a 1000x mismatch; fix by either
multiplying each histogram_quantile(...) expression by 1000 (e.g. 1000 *
histogram_quantile(...)) or change the panel unit from "ms" to "s" for both
"Status Update Duration" and "Resource Apply Duration" panels; update
occurrences referencing histogram_quantile,
status_update_duration_seconds_bucket and resource_apply_duration_seconds_bucket
accordingly (also apply the same change at the other location mentioned).
- Line 1149: The "Endpoint Health Percentage (Route)" Prometheus expression
currently ends with " > 0", which turns the ratio into a boolean; update the
query used in that panel (the expression starting with avg
by(envoy_cluster_name)
(envoy_cluster_membership_healthy{gateway_namespace=~"$namespace",gateway=~"$gateway",envoy_cluster_name=~"$route"})
/ avg by(envoy_cluster_name)
(envoy_cluster_membership_total{gateway_namespace=~"$namespace",gateway=~"$gateway",envoy_cluster_name=~"$route"})
> 0) by removing the comparison and returning the raw ratio (or multiply by 100
to present a percentage) so the panel shows the actual endpoint health
percentage rather than 0/1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 79ce778a-233b-4270-aed5-5fed594cef59
📒 Files selected for processing (1)
docs/en/solutions/How_to_add_Dashboard_for_EnvoyGateway.md
Summary by CodeRabbit