Use ArrayVec::push_many_from_slice to make code safer#5
Open
Ericson2314 wants to merge 1 commit intoprompt-queueingfrom
Open
Use ArrayVec::push_many_from_slice to make code safer#5Ericson2314 wants to merge 1 commit intoprompt-queueingfrom
ArrayVec::push_many_from_slice to make code safer#5Ericson2314 wants to merge 1 commit intoprompt-queueingfrom
Conversation
Contributor
|
Looks cleaner to me. |
We were ignoring potential (even though it shouldn't happen) failure. The new way however is correct by construction. The `ArrayVec` method is from bluss/arrayvec#237
Ericson2314
force-pushed
the
push-many-from-slice
branch
from
d8fa38c to
4316f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were ignoring potential (even though it shouldn't happen) failure. The new way however is correct by construction.
The
ArrayVecmethod is from bluss/arrayvec#237