-
Notifications
You must be signed in to change notification settings - Fork 312
feat(promotion): add ignoreMissingValueFiles to helm-template step #5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(promotion): add ignoreMissingValueFiles to helm-template step #5522
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I'm not specifically opposed to this, but I do vaguely recall some prior discussion about this, or else it was a very similar conversation. Whether it was on this exact topic or just similar one, I think @hiddeco may have once expressed some reluctance to the idea of steps that wrap a tool (like helm) having options that the tool itself lacks.
It is quite possible I am mis-remembering the aforementioned conversation, so let's have @hiddeco weigh in. fwiw, there is another way to do this in v1.9.0. There's a step that merges a list of YAML files and it already has an option to ignore any that are missing. It would be possible to use that first to merge your YAML files (from most general to most specific) and then use helm template on the one resulting file. |
|
I missed that there is new step for merging YAML (i see that it has this flag implemented). My reasoning was to bring Kargo on par with ArgoCD, as some folks (including myself) run mix of both (e.g. ArgoCD managed apps for dev, PoCs, etc. and rendered manifests via Kargo for staging and prod). Of course I can wrap @hiddeco it is your call then if it is worth to have this or not |
|
My concern with a flag at a global level like this is that it opens the gates for incidents where e.g. a typo results in something to go unnoticed because any path is allowed to be missing. I would be more open to the idea of allowing specific paths to be optional. But the problem with this (and the current API) is that the list of values files is just a simple list (and you can't add fields per list item). |
|
I do believe we had the same discussion for the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
=======================================
Coverage 55.51% 55.51%
=======================================
Files 429 429
Lines 31954 31957 +3
=======================================
+ Hits 17738 17741 +3
Misses 13208 13208
Partials 1008 1008 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes akuity#4349 Signed-off-by: Ksawery Karwacki <ksawery.karwacki@gmail.com>
1e69576 to
344fa1c
Compare
Summary
ignoreMissingValueFilesboolean option to thehelm-templatepromotion stepCloses #4349