Skip to content

feat(promotion): add pollInterval configuration#5313

Closed
mrfelton wants to merge 1 commit intoakuity:mainfrom
mrfelton:feat/http-poll
Closed

feat(promotion): add pollInterval configuration#5313
mrfelton wants to merge 1 commit intoakuity:mainfrom
mrfelton:feat/http-poll

Conversation

@mrfelton
Copy link
Copy Markdown

I'm mostly just throwing this PR together to help facilitate a question related to the discussion in #4969 - not expecting this to be properly reviewed or merged etc. So take it for what it is.

I'm not familiar with the codebase at all, but from what I gather, returning RetryAfter from these steps should be enough to prompt a more timely polling?

@krancour - just curious if an approach like this would work in principle? Or if this is more or less aligned with your vision of how to solve for the polling scenarios.


This pull request introduces support for a configurable polling interval (pollInterval) for both the Git PR waiter and HTTP requester promotion steps. This allows users to specify how frequently these steps should poll for status updates, improving flexibility and responsiveness. If the interval is not specified or is invalid, the system falls back to the default 5-minute requeue interval. The changes include updates to configuration schemas, code logic, and documentation.

Polling interval support for promotion steps:

  • Added a new pollInterval field to both GitWaitForPRConfig and HTTPConfig structs, allowing users to specify a custom polling interval. [1] [2]
  • Updated JSON schemas (git-wait-for-pr-config.json, http-config.json) to validate and document the new pollInterval field, including accepted formats and default behavior. [1] [2]
  • Modified the logic in git_pr_waiter.go and http_requester.go to parse the pollInterval value and set the RetryAfter field accordingly. If the interval is invalid, a warning is logged and the default is used. [1] [2] [3]

Documentation updates:

  • Updated user guide reference docs for both the Git PR waiter and HTTP requester steps to describe the new pollInterval option and its default behavior. [1] [2]

@mrfelton mrfelton requested review from a team as code owners October 30, 2025 19:13
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 30, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4c70071
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/6904545323f0f50008f87f23
😎 Deploy Preview https://deploy-preview-5313.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@krancour krancour self-assigned this Oct 30, 2025
…nd http steps

Signed-off-by: Tom Kirkpatrick <tom@strike.me>
@aslafy-z
Copy link
Copy Markdown
Contributor

aslafy-z commented Dec 5, 2025

I'm also really interested into this change. I need the pr waiter to pick up changes faster!

@krancour
Copy link
Copy Markdown
Member

With apologies, I'm closing all PRs related to #5313 until adequate discussion and due diligence have been performed.

See #4969 (comment)

@krancour krancour closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants