feat(promotion): add pollInterval configuration#5313
Closed
mrfelton wants to merge 1 commit intoakuity:mainfrom
Closed
feat(promotion): add pollInterval configuration#5313mrfelton wants to merge 1 commit intoakuity:mainfrom
mrfelton wants to merge 1 commit intoakuity:mainfrom
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…nd http steps Signed-off-by: Tom Kirkpatrick <tom@strike.me>
9255cef to
4c70071
Compare
Contributor
|
I'm also really interested into this change. I need the pr waiter to pick up changes faster! |
Member
|
With apologies, I'm closing all PRs related to #5313 until adequate discussion and due diligence have been performed. See #4969 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm mostly just throwing this PR together to help facilitate a question related to the discussion in #4969 - not expecting this to be properly reviewed or merged etc. So take it for what it is.
I'm not familiar with the codebase at all, but from what I gather, returning
RetryAfterfrom these steps should be enough to prompt a more timely polling?@krancour - just curious if an approach like this would work in principle? Or if this is more or less aligned with your vision of how to solve for the polling scenarios.
This pull request introduces support for a configurable polling interval (
pollInterval) for both the Git PR waiter and HTTP requester promotion steps. This allows users to specify how frequently these steps should poll for status updates, improving flexibility and responsiveness. If the interval is not specified or is invalid, the system falls back to the default 5-minute requeue interval. The changes include updates to configuration schemas, code logic, and documentation.Polling interval support for promotion steps:
pollIntervalfield to bothGitWaitForPRConfigandHTTPConfigstructs, allowing users to specify a custom polling interval. [1] [2]git-wait-for-pr-config.json,http-config.json) to validate and document the newpollIntervalfield, including accepted formats and default behavior. [1] [2]git_pr_waiter.goandhttp_requester.goto parse thepollIntervalvalue and set theRetryAfterfield accordingly. If the interval is invalid, a warning is logged and the default is used. [1] [2] [3]Documentation updates:
pollIntervaloption and its default behavior. [1] [2]