refactor!: moved ErrInternal to the chain-sdk

CHANGELOG.md

@@ -47,3 +47,5 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ### Bug Fixes
 
 * Fix bug in ditribution and querying rewards
+
+* Moved x/provider/handler.ErrInternal to the chain-sdk/go/node/provider/v1beta4 package.

x/provider/handler/handler_test.go

@@ -253,8 +253,8 @@ func TestProviderDeleteExisting(t *testing.T) {
 
 	res, err := suite.handler(suite.ctx, deleteMsg)
 	require.Nil(t, res)
-	require.EqualError(t, err, "NOTIMPLEMENTED: "+handler.ErrInternal.Error())
-	require.True(t, errors.Is(err, handler.ErrInternal))
+	require.EqualError(t, err, "NOTIMPLEMENTED: "+types.ErrInternal.Error())
+	require.True(t, errors.Is(err, types.ErrInternal))
 
 	t.Run("ensure event created", func(_ *testing.T) {
 		// TODO: this should emit a ProviderDelete

x/provider/handler/server.go

@@ -3,7 +3,7 @@
 import (
 	"context"
 
-	errorsmod "cosmossdk.io/errors"
+	sdkerrors "cosmossdk.io/errors"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	types "pkg.akt.dev/go/node/provider/v1beta4"
@@ -12,11 +12,6 @@
 	"pkg.akt.dev/node/x/provider/keeper"
 )
 
-var (
-	// ErrInternal defines registered error code for internal error
-	ErrInternal = errorsmod.Register(types.ModuleName, 10, "internal error")
-)
-
 type msgServer struct {
 	provider keeper.IKeeper
 	market   mkeeper.IKeeper
@@ -44,7 +39,7 @@
 	}
 
 	if err := ms.provider.Create(ctx, types.Provider(*msg)); err != nil {
-		return nil, ErrInternal.Wrapf("err: %v", err)
+		return nil, types.ErrInternal.Wrapf("err: %v", err)
 	}
 
 	return &types.MsgCreateProviderResponse{}, nil
@@ -65,7 +60,7 @@
 	}
 
 	if err := ms.provider.Update(ctx, types.Provider(*msg)); err != nil {
-		return nil, errorsmod.Wrapf(ErrInternal, "err: %v", err)
+		return nil, sdkerrors.Wrapf(types.ErrInternal, "err: %v", err)
 	}
 
 	return &types.MsgUpdateProviderResponse{}, nil
@@ -84,5 +79,5 @@
 	}
 
 	// TODO: cancel leases
-	return nil, ErrInternal.Wrap("NOTIMPLEMENTED")
+	return nil, types.ErrInternal.Wrap("NOTIMPLEMENTED")
 }