refactor(kafka_topic): migrate KafkaTopic to Reconciler[T]#1100
Merged
Conversation
Contributor
Author
|
/test |
Contributor
✅ Acceptance Tests PassedWorkflow: View Details |
6d78722 to
b6b6a70
Compare
vmyroslav
reviewed
Jan 29, 2026
vmyroslav
reviewed
Jan 29, 2026
Contributor
|
I would add to the change log the detailed explanation of changes which might be breaking for someone. Like the fact that now operator WILL re-create the deleted topics. |
b6b6a70 to
e202ef6
Compare
vmyroslav
previously approved these changes
Jan 30, 2026
…es deleted topics
Contributor
Author
|
/test |
Contributor
✅ Acceptance Tests PassedWorkflow: View Details |
vmyroslav
approved these changes
Jan 30, 2026
vmyroslav
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this change—what it does
Resolves: #NEX-2284.
Migrates
KafkaTopicto the shared genericReconciler[T]and adds scenario tests to lock in behavior.What stays the same:
instance-is-runningannotation + Running condition).termination_protection; NotFound on delete is treated as success.ServiceKafkaTopicListcalls per service.Behavior changes / important notes:
KafkaTopicresource still exists, the operator will re-create it.ServiceKafkaTopicListare treated as retryable without treating the topic as missing. During spec updates we assume the topic exists if it was applied before to avoid going throughCreateand hittingAlreadyExists.Out of scope:
Tests: