Skip to content

chore(deps): update nltk to 3.9.4#968

Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 3 commits intomainfrom
devin/1774667708-update-nltk-cryptography
Draft

chore(deps): update nltk to 3.9.4#968
Aaron ("AJ") Steers (aaronsteers) wants to merge 3 commits intomainfrom
devin/1774667708-update-nltk-cryptography

Conversation

@aaronsteers
Copy link
Copy Markdown
Member

@aaronsteers Aaron ("AJ") Steers (aaronsteers) commented Mar 28, 2026

Summary

Updates nltk from 3.9.13.9.4 (patch release). This is an optional dependency used by file-based connectors via unstructured_parser.py for document tokenization.

No other dependency changes are included. The cryptography range is unchanged.

Notes on the lockfile diff

The poetry.lock was regenerated with Poetry 2.3.3 (repo previously used 2.0.1). The lockfile diff is large because Poetry 2.3.3 rewrites marker expressions across all packages (e.g., python_version <= "3.11" or python_version >= "3.12"python_version <= "3.13.0"). The only substantive dependency change is nltk.

Review & Testing Checklist for Human

  • nltk 3.9.4 changelog: Review the nltk 3.9.4 release notes for any breaking changes that could affect file-based connectors using unstructured_parser.py (punkt tokenizer, averaged_perceptron_tagger_eng).
  • Poetry 2.3.3 marker reformatting: The lockfile was regenerated with a newer Poetry version, which changed marker expressions across many packages. Verify CI passes across all Python versions (3.10–3.13).

Suggested test plan: Let CI run the full pytest matrix (Python 3.10–3.13) and confirm all tests pass. A companion PR in the monorepo pins three file-based connectors (source-s3, source-google-drive, source-azure-blob-storage) to this branch for integration validation.

Notes

  • The poetry.lock diff is large but almost entirely marker reformatting from the Poetry version bump. The only substantive dependency change is nltk.

Link to Devin session: https://app.devin.ai/sessions/51acbfaadcd441d782d3a1817d6d413d
Requested by: Aaron ("AJ") Steers (@aaronsteers)

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1774667708-update-nltk-cryptography#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1774667708-update-nltk-cryptography

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

PyTest Results (Fast)

3 945 tests  +11   3 933 ✅ +10   6m 43s ⏱️ -16s
    1 suites ± 0      12 💤 + 1 
    1 files   ± 0       0 ❌ ± 0 

Results for commit a1b1635. ± Comparison against base commit acafc75.

This pull request skips 1 test.
unit_tests.sources.declarative.test_concurrent_declarative_source ‑ test_read_with_concurrent_and_synchronous_streams

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

PyTest Results (Full)

3 948 tests  +11   3 936 ✅ +11   11m 11s ⏱️ +22s
    1 suites ± 0      12 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit a1b1635. ± Comparison against base commit acafc75.

♻️ This comment has been updated with latest results.

@devin-ai-integration devin-ai-integration bot changed the title chore(deps): update nltk to 3.9.4 and widen cryptography range to <47.0.0 chore(deps): update nltk to 3.9.4 Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant