-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Add block_simultaneous_read with top-level stream_groups interface #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alfredo Garcia (agarctfi)
merged 30 commits into
main
from
tolik0/concurrent-source/add-block_simultaneous_read
Mar 31, 2026
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4475a94
Add block_simultaneous_read to DefaultStream
tolik0 54631ac
Change `block_simultaneous_read` to string
tolik0 5bf631e
Fix StreamFacade
tolik0 0758005
Fix NoneType error when all streams are blocked
tolik0 06abd41
Fix unit tests
tolik0 61c1072
Auto-fix lint and format issues
1c1555b
Add retry deferred streams on stream completion
tolik0 b3a98f4
Fix unit tests
tolik0 0377b80
More fixes for unit tests
tolik0 8acab48
refactor: replace per-stream block_simultaneous_read with top-level s…
devin-ai-integration[bot] c33a61b
refactor: move stream_name_to_group into ModelToComponentFactory
devin-ai-integration[bot] 8efc56c
refactor: use stream_groups manifest in factory test instead of hardc…
devin-ai-integration[bot] 4bf56ec
fix: only include parent stream in stream_groups to avoid deadlock
devin-ai-integration[bot] 276c007
style: fix ruff format for long line
devin-ai-integration[bot] 59fbd79
refactor: move _build_stream_name_to_group into ModelToComponentFactory
devin-ai-integration[bot] 40d53e7
refactor: resolve stream_groups from actual stream instances instead …
devin-ai-integration[bot] 6726050
Fix stream format in schema
tolik0 76a29f2
refactor: add get_partition_router() helper to DefaultStream
devin-ai-integration[bot] b6be8c8
feat: validate no parent-child streams share a group to prevent deadlock
devin-ai-integration[bot] 3f5a354
feat: assert partition generation queue is empty when all streams are…
devin-ai-integration[bot] 4b8b141
refactor: move inline imports to module level in default_stream.py an…
devin-ai-integration[bot] 7306516
fix: unwrap GroupingPartitionRouter in get_partition_router() to dete…
devin-ai-integration[bot] c4c9270
fix: handle GroupingPartitionRouter at call sites instead of in get_p…
devin-ai-integration[bot] f1e020b
feat: check active_groups is empty in is_done() safety check
devin-ai-integration[bot] e027b73
test: add missing unit tests for GroupingPartitionRouter, active_grou…
devin-ai-integration[bot] 6f52073
fix: make deadlock validation check all ancestors, not just direct pa…
devin-ai-integration[bot] e7acac8
style: alphabetize StreamGroup and BlockSimultaneousSyncsAction in sc…
devin-ai-integration[bot] b56b376
style: move BlockSimultaneousSyncsAction next to StreamGroup for easi…
devin-ai-integration[bot] 055655a
fix: update test regex to match actual error message after rebase
devin-ai-integration[bot] 22ef57b
fix: correct ruff formatting and update active_groups test regex to m…
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
232 changes: 218 additions & 14 deletions
232
airbyte_cdk/sources/concurrent_source/concurrent_read_processor.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.