Skip to content

Fix: ESLint 9+ path: handle child script errors in whitespace-async.js #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dataCenter430 wants to merge 4 commits into
base: master
Choose a base branch
from
+34 −8
Open

Fix: ESLint 9+ path: handle child script errors in whitespace-async.js #3239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22cf1cf
Fix ESLint 9+ path: handle child script errors in whitespace-async.js
dataCenter430 Mar 6, 2026
e3c0258
fix: support ESLint 9+ by using legacy config for async path
dataCenter430 Mar 9, 2026
4585c72
Trigger CI
dataCenter430 Mar 9, 2026
eb9b352
Trigger GitHub to recheck rebaseability
dataCenter430 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/eslint-config-airbnb-base/whitespace-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { isArray } = Array;
const { entries } = Object;
const { ESLint } = require('eslint');
const eslint = require('eslint');

const baseConfig = require('.');
const whitespaceRules = require('./whitespaceRules');
Expand All @@ -21,11 +21,18 @@ function getSeverity(ruleConfig) {

async function onlyErrorOnRules(rulesToError, config) {
const errorsOnly = { ...config };
const cli = new ESLint({
const ESLintClass = typeof eslint.loadESLint === 'function'
? await eslint.loadESLint({ useFlatConfig: false })
: eslint.ESLint;
const cli = new ESLintClass({
useEslintrc: false,
baseConfig: config
});
const baseRules = (await cli.calculateConfigForFile(require.resolve('./'))).rules;
const resolvedPath = require.resolve('./');
const configForFile = typeof cli.getConfigForFile === 'function'
? cli.getConfigForFile(resolvedPath)
: await cli.calculateConfigForFile(resolvedPath);
const baseRules = configForFile.rules;

entries(baseRules).forEach((rule) => {
const ruleName = rule[0];
Expand All @@ -46,4 +53,9 @@ async function onlyErrorOnRules(rulesToError, config) {
return errorsOnly;
}

onlyErrorOnRules(whitespaceRules, baseConfig).then((config) => console.log(JSON.stringify(config)));
onlyErrorOnRules(whitespaceRules, baseConfig)
.then((config) => console.log(JSON.stringify(config)))
.catch((err) => {
console.error(err);
process.exit(1);
});
1 change: 1 addition & 0 deletions packages/eslint-config-airbnb-base/whitespace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ if (CLIEngine) {
env: {
...process.env,
TIMING: undefined,
ESLINT_USE_FLAT_CONFIG: 'false',
}
})));
}
20 changes: 16 additions & 4 deletions packages/eslint-config-airbnb/whitespace-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { isArray } = Array;
const { entries } = Object;
const { ESLint } = require('eslint');
const eslint = require('eslint');

const baseConfig = require('.');
const whitespaceRules = require('./whitespaceRules');
Expand All @@ -21,11 +21,18 @@ function getSeverity(ruleConfig) {

async function onlyErrorOnRules(rulesToError, config) {
const errorsOnly = { ...config };
const cli = new ESLint({
const ESLintClass = typeof eslint.loadESLint === 'function'
? await eslint.loadESLint({ useFlatConfig: false })
: eslint.ESLint;
const cli = new ESLintClass({
useEslintrc: false,
baseConfig: config
});
const baseRules = (await cli.calculateConfigForFile(require.resolve('./'))).rules;
const resolvedPath = require.resolve('./');
const configForFile = typeof cli.getConfigForFile === 'function'
? cli.getConfigForFile(resolvedPath)
: await cli.calculateConfigForFile(resolvedPath);
const baseRules = configForFile.rules;

entries(baseRules).forEach((rule) => {
const ruleName = rule[0];
Expand All @@ -46,4 +53,9 @@ async function onlyErrorOnRules(rulesToError, config) {
return errorsOnly;
}

onlyErrorOnRules(whitespaceRules, baseConfig).then((config) => console.log(JSON.stringify(config)));
onlyErrorOnRules(whitespaceRules, baseConfig)
.then((config) => console.log(JSON.stringify(config)))
.catch((err) => {
console.error(err);
process.exit(1);
});
1 change: 1 addition & 0 deletions packages/eslint-config-airbnb/whitespace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ if (CLIEngine) {
env: {
...process.env,
TIMING: undefined,
ESLINT_USE_FLAT_CONFIG: 'false',
}
})));
}