Allow decompression to continue after exceeding max_length#11966
Allow decompression to continue after exceeding max_length#11966Dreamsorcerer merged 222 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11966 +/- ##
==========================================
+ Coverage 98.89% 98.92% +0.02%
==========================================
Files 133 133
Lines 46257 46550 +293
Branches 2405 2423 +18
==========================================
+ Hits 45746 46048 +302
+ Misses 379 373 -6
+ Partials 132 129 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging this PR will degrade performance by 45.32%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_one_hundred_get_requests_iter_chunks_on_10mb_chunked_payload[pyloop] |
1.2 s | 1.1 s | +8.5% |
| 👁 | test_get_request_with_251308_compressed_chunked_payload[zlib_ng.zlib_ng-pyloop] |
207 ms | 244.4 ms | -15.32% |
| 👁 | test_get_request_with_251308_compressed_chunked_payload[isal.isal_zlib-pyloop] |
62.1 ms | 113.5 ms | -45.32% |
| ⚡ | test_one_thousand_round_trip_websocket_binary_messages[pyloop-large] |
110.6 ms | 101.7 ms | +8.7% |
| ⚡ | test_read_large_binary_websocket_messages[pyloop] |
8,940.3 µs | 49 µs | ×180 |
| ⚡ | test_ten_streamed_responses_iter_chunks[pyloop] |
131.5 ms | 119.6 ms | +9.9% |
| ⚡ | test_ten_streamed_responses_iter_chunked_1mb[pyloop] |
1.2 s | 1.1 s | +10.11% |
| 👁 | test_ten_streamed_responses_iter_chunked_4096[pyloop] |
28.2 ms | 35.5 ms | -20.68% |
Comparing Dreamsorcerer-patch-5 (293d7f6) with master (b5f1aa5)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
for more information, see https://pre-commit.ci
…nto Dreamsorcerer-patch-5
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 0c7ce34 on top of patchback/backports/3.14/0c7ce3485dbcda196e125b4ea913a67e6b54f26c/pr-11966 Backporting merged PR #11966 into master
🤖 @patchback |
(cherry picked from commit 0c7ce34)
Architecture summary:
b""to get more data. The decompression output has been reduced to 256KiB, matching the socket read limit.b"".