feat(sqlalchemy): maxLength validator from char_length constraints#1170
Draft
aiolibsbot wants to merge 1 commit into
Draft
feat(sqlalchemy): maxLength validator from char_length constraints#1170aiolibsbot wants to merge 1 commit into
aiolibsbot wants to merge 1 commit into
Conversation
_get_validators translated char_length(col) >= N / > N check constraints into minLength validators, but silently dropped the <= N / < N forms — so a max-length CheckConstraint on a Text column (no fixed .length) produced no client-side validation. Now symmetric with the numeric ge/gt/le/lt and the minLength handling: <= N -> maxLength(N), < N -> maxLength(N-1). Part of aio-libs#666. Frontend already handles the maxLength validator, so no admin-js change is needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
+ Coverage 95.56% 95.64% +0.07%
==========================================
Files 21 21
Lines 2954 2962 +8
Branches 193 195 +2
==========================================
+ Hits 2823 2833 +10
+ Misses 105 103 -2
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Translate
char_length(col) <= N/< Ncheck constraints intomaxLengthinput validators.Why
_get_validatorsalready turnedchar_length(col) >= N/> Nconstraints intominLengthvalidators, and it handles the fullge/gt/le/ltrange for numeric bounds. But the<=/<char-length cases fell through silently — aCheckConstraint(func.char_length(col) <= N)on aTextcolumn (no fixed.length) produced zero client-side max-length validation. This closes that asymmetry. Part of #666.How
Added
le -> maxLength(N)andlt -> maxLength(N-1)branches alongside the existingge/gtminLength handling. The-1for the strict<mirrors the numericlt -> maxValue(N-1)convention. Frontend already deserializes themaxLengthvalidator, so no admin-js change.Testing
Extended
test_check_constraintswith<=and<char-length columns assertingmaxLength(5)andmaxLength(4). Full suite: 97 passed, 1 xfailed; the lonetest_admin_viewfailure is pre-existing (#934) and unrelated.Quality Report
Changes: 2 files changed, 10 insertions(+)
Code scan: clean
Tests: failed (command not found)
Branch hygiene: clean
Generated by Kōan