Relax botocore dependency specification#1461
Merged
jakob-keller merged 1 commit intoaio-libs:masterfrom Jan 2, 2026
Merged
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 76 76
Lines 8080 8080
=======================================
Hits 7402 7402
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thehesiod
approved these changes
Jan 2, 2026
thehesiod
pushed a commit
that referenced
this pull request
Apr 19, 2026
…cal mislabel 32 scenarios covering the full set of merged botocore sync PRs. Each row now has: - A draft rationale generated from inspecting the botocore diff (new def count, async-signal count, added-line count), wrapped to ≤120 chars to satisfy project yamllint. - A mislabel-suspicion heuristic that flagged 3 rows for manual review. Historical mislabel caught: - PR #1428 titled "Bump" (→ port-required by convention) but both botocore and aiobotocore diffs show only __init__.py version bump. Fixed: expected overridden to `no-port`, with a notes field documenting the title/classification divergence. False alarms resolved: - PRs #1461, #1466 triggered the async-signal heuristic but manual review confirmed the signals are in non-overridden paths. Notes clarify the heuristic context. Other changes: - generate_scenarios.py now uses full relative paths (not basenames) to identify overridden files, fixing a false-positive where e.g. `botocore/docs/client.py` wrongly matched `aiobotocore/client.py`. - Scenarios rendered with top-level sequence items unindented and sub-keys at 2-space indent, matching project .yamllint (indent-sequences: false). - Added aiobotocore ↔ botocore correlation notes to evals/README.md, including the caveat that aiobotocore can bump its own version for reasons unrelated to a botocore sync. - check_async_need.py parser updated to the new YAML indentation.
thehesiod
pushed a commit
that referenced
this pull request
Apr 19, 2026
Three doc updates driven by the PR-archaeology pass: 1. Sync prompt Step 3: add "classifier is the authority, not the PR title" guidance. PR #1428 was mislabeled "Bump" but was actually a no-port. The bot's verdict should win; update the title to match. 2. check-async-need.md: add "Common false-positive signal patterns" section documenting the FP categories the archaeology surfaced (string literals, docstrings, comments, test fixtures, unreached paths, botocore/data/). PRs #1461 and #1466 both triggered these FPs. 3. CONTRIBUTING.rst: state that sync PRs should be tightly scoped (just the pin update + any ports), since bundled unrelated fixes make the classifier noisier and reviewers confused. Also reinforces that mislabels are treated as data to correct, not as the authoritative truth.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR intends to improve general compatibility of
aiobotocorewithin the Python ecosystem by relaxing the dependency specification ofbotocore.Assumptions
Upstream contains no changes that require adjustments to the aiobotocore codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions