fix(cli): Author docs/insights.md per recommendations.md shape and ... (#1578)#61
Draft
aidandaly24 wants to merge 1 commit into
Draft
fix(cli): Author docs/insights.md per recommendations.md shape and ... (#1578)#61aidandaly24 wants to merge 1 commit into
aidandaly24 wants to merge 1 commit into
Conversation
Add docs/insights.md (modeled on docs/recommendations.md) plus a README docs-index link for the Insights [preview] feature. Correct the advertised run-insights examples in copy.ts to use the real flags --insights and --lookback-days (the old -i and --lookback are not registered). Add a regression test guarding the corrected copy. Refs aws#1578
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs aws#1578
Issues
-iand--lookbackthat the command never registers.Root cause
Verified directly: docs/insights.md absent (ls/find), docs/recommendations.md present, README.md:156-168/318 state confirmed, PR aws#1577 (954b97b) git show --stat shows only README.md + AGENTS.md, all cited command/primitive/operation files read and confirmed real at HEAD e92c79a. The copy.ts run-insights examples used
-i FailureAnalysisand--lookback 7, butrun insightsregisters--insightsand-d, --lookback-daysonly.The fix
Author docs/insights.md per recommendations.md shape and add README docs-index link; correct the real flags to
--insights Builtin.Insight.FailureAnalysisand--lookback-daysin copy.ts; add a regression test guarding the corrected copy.Files touched: NEW docs/insights.md (model: docs/recommendations.md); README.md docs index ~line 318 (Evaluation & quality block); src/cli/tui/copy.ts:130-148; NEW src/cli/tui/tests/run-insights-copy.test.ts
Validation evidence
The fix was verified by reproducing the original symptom and re-running after the change:
Test suite: green.
Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.