fix(unit-only): see the_fix field (#1610)#58
Draft
aidandaly24 wants to merge 1 commit into
Draft
Conversation
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs aws#1610
Issues
agentcore deploy(bare TUI path, isInteractive:false) where CloudFormation enters ROLLBACK_IN_PROGRESS and then the terminal ROLLBACK_FAILED state, the TUI keeps showing the frozen "Deploying to AWS" banner with a static/bouncing progress bar for minutes, giving the impression that the deploy has hung. It is not a permanent hang: once CFN reaches the terminal ROLLBACK_FAILED state, toolkit-lib throws, the CLI catches it, marks the step errored, and exits. The user just gets no feedback that a rollback is happening, then the screen looks stuck until the (possibly long) rollback completes/fails.Root cause
see root_cause field
The fix
see the_fix field
Files touched: src/cli/tui/components/DeployStatus.tsx (ResourceStatus union ~60-69, parseResourceMessage regex ~104-108, getStatusColor ~79-84, banner label ~195); src/cli/cdk/toolkit-lib/types.ts (DEPLOY_MESSAGE_CODES / extractProgressFromMessage ~64-86 if rollback events need richer surfacing); src/cli/tui/screens/deploy/useDeployFlow.ts (onMessage handler ~761-776 to detect first rollback event and set a notice). No change needed in node_modules toolkit-lib (its stack-status.js already classifies ROLLBACK_FAILED correctly) or the error/exit chain (useDeployFlow.ts:881-912, DeployScreen.tsx:183-187 already work).
Validation evidence
The fix was verified by reproducing the original symptom and re-running after the change:
Test suite: green.
Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.