Skip to content

feat(refine): remove condense skill and its hook - #624

Merged
blafourcade merged 1 commit into
nextfrom
feat/refine-remove-condense
Aug 13, 2026
Merged

feat(refine): remove condense skill and its hook#624
blafourcade merged 1 commit into
nextfrom
feat/refine-remove-condense

Conversation

@blafourcade

Copy link
Copy Markdown
Contributor

🎯 What & why

Removes aidd-refine:03-condense and the UserPromptSubmit hook that backed it. The skill overlapped with the host tool's own output settings, and its 02-stats action depended on the model emitting a literal Condense: ON (<level>). marker that it paraphrased in practice — a limitation the eval harness already documented as a known finding rather than a bug worth fixing.

🛠️ How it works

Three moves, in order:

  1. Delete skills/03-condense/ and hooks/. hooks.json registered only the condense hook, so the whole directory goes rather than leaving an empty manifest behind. aidd-context is now the only plugin shipping hooks — docs/ARCHITECTURE.md drops to a single row.
  2. Renumber to stay contiguous, via git mv so rename detection survives review: 04-shadow-areas03-shadow-areas, 05-fact-check04-fact-check. Both SKILL.md frontmatter name: fields follow.
  3. Chase every reference. Nothing outside the plugin cited the moved skills — a repo-wide sweep found only aidd-refine:01-brainstorm and aidd-refine:02-challenge referenced from other plugins (checker.md:46, 03-check.md:26, the cook recipes, idle-menu.md), and neither moves. So the renumber is safe for every other plugin.

Two details worth a reviewer's eye:

  • plugin.json and marketplace.json carried a byte-identical description string mentioning "condensed communication mode". Both are rewritten to the same new string so they can't drift.
  • 02-verify.md:24 used hooks/condense-stats.js as its worked example of a file that exists. Deleting the hook would have inverted the test, so the example now points at plugins/aidd-context/hooks/update_memory.js.

CATALOG.md and the README counts are auto-generated; both were regenerated with the exact invocations from lefthook.yml rather than hand-edited.

Deliberately untouched: cli/tests/fixtures/framework-real/ is a pinned v4.1.0-beta.12 snapshot with its own refresh script, and framework-build-golden.e2e.test.ts:34 builds from that fixture rather than the live tree — so the condense strings still in golden.json are correct and must stay. CHANGELOGs are history.

🧪 How to verify

Run the real pre-commit gates:

node scripts/validate-json.mjs .claude-plugin/marketplace.json plugins/aidd-refine/.claude-plugin/plugin.json
node scripts/check-skill-argument-hints.mjs
node scripts/check-markdown-links.js --ignore cli/tests/fixtures --ignore cli/aidd_docs/tasks
node scripts/sync-readme-counts.mjs --check

All four pass on this branch (✅ Links: 0 broken in 673 files; README settles at 4 skills for aidd-refine, 47 total).

Confirm nothing stale is left behind:

grep -rn "03-condense\|04-shadow-areas\|05-fact-check" \
  --exclude-dir={node_modules,.git,fixtures,snapshots} . | grep -v CHANGELOG

Returns nothing.

⚠️ Heads-up

  • Breaking for pinned references. Anyone invoking aidd-refine:04-shadow-areas or aidd-refine:05-fact-check by name must update to the new numbers. The commit carries BREAKING CHANGE: so release-please bumps aidd-refine accordingly; .release-please-manifest.json is left at 2.2.4 for the tooling to own.
  • The 03-condense eval case is removed from scripts/skill-eval/cases.json, and its entry under "Known findings" in the harness README goes with it.

The condense skill duplicated a concern that belongs to the host tool's
own output settings, and its `UserPromptSubmit` hook parsed a marker line
the model emitted only inconsistently (see the eval harness's own "known
findings" note). Rather than harden a best-effort mechanism, drop it.

Removing `03-condense` frees the slot, so the two skills after it move up
to keep the plugin's numbering contiguous.

BREAKING CHANGE: `aidd-refine:03-condense` is removed, and the skills
after it are renumbered: `04-shadow-areas` becomes `03-shadow-areas`, and
`05-fact-check` becomes `04-fact-check`. Any pinned reference to the old
names must be updated. The plugin no longer ships a hooks directory.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@blafourcade
blafourcade force-pushed the feat/refine-remove-condense branch from d6d7cfc to be14ae9 Compare August 13, 2026 05:18
@blafourcade blafourcade changed the title feat(refine)!: remove condense skill and its hook feat(refine): remove condense skill and its hook Aug 13, 2026
@blafourcade
blafourcade marked this pull request as ready for review August 13, 2026 05:19
@blafourcade
blafourcade requested a review from a team as a code owner August 13, 2026 05:19
@blafourcade
blafourcade merged commit 088df33 into next Aug 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant