Skip to content

[AAASM-4067] 🐛 (release): Fix runtime npm publish path (./ prefix)#230

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4067/fix/npm_publish_local_path
Jul 4, 2026
Merged

[AAASM-4067] 🐛 (release): Fix runtime npm publish path (./ prefix)#230
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4067/fix/npm_publish_local_path

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

What

release-node.yml line 379: npm publish ... "packages/${pkg}""./packages/${pkg}".

Why

The rc.3 real publish (publish_mode=all) failed at the first runtime sub-package:

npm publish --access public --provenance --tag rc "packages/runtime-linux-x64"
npm error command git ls-remote ssh://git@github.com/packages/runtime-linux-x64.git
npm error git@github.com: Permission denied (publickey)

Newer npm parses the bare packages/runtime-linux-x64 as a GitHub owner/repo shorthand and tries to clone it over SSH instead of publishing the local folder. rc.2 published fine — GitHub-runner npm spec-parsing drifted (same runner-drift class as the core rc.3 break). The ./ prefix forces local-directory interpretation. Main SDK publish (line 404) has no path arg, so it's unaffected.

Nothing reached npm in the failed run (runtime pkgs publish before the main SDK; first runtime pkg failed) — the 0.0.1-rc.3 slot is intact.

How to verify

Re-dispatch release-node.yml (publish_mode=all, npm_version=0.0.1-rc.3) — the runtime loop publishes all 4 @agent-assembly/runtime-*@0.0.1-rc.3 + main SDK. Closes AAASM-4067.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MvjnG3ysnqTY6Gu1wQ2h73

…epo shorthand

release-node.yml passed a bare packages/${pkg} to npm publish; newer npm
parses it as a GitHub owner/repo spec and git-ls-remotes it over SSH instead
of publishing the local folder. ./ forces local-directory interpretation.

Refs AAASM-4067.
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@Chisanan232 Chisanan232 merged commit c814fe6 into master Jul 4, 2026
25 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-4067/fix/npm_publish_local_path branch July 4, 2026 01:07
@Chisanan232

Copy link
Copy Markdown
Contributor Author

Claude Code — review record

1. CI: ✅ no failing checks (workflow-file change).
2. Scope: ✅ one line — release-node.yml line 379 "packages/${pkg}""./packages/${pkg}" + a why-comment. Exactly the git ls-remote ssh://.../packages/runtime-linux-x64.git blocker.
3. Side-effects: ✅ none — publish-time behavior identical except npm now resolves the runtime sub-package as a local folder instead of a GitHub owner/repo shorthand. Main SDK publish (line 404, no path arg) untouched. dry-run path unaffected.

Verdict: Ready to merge. After merge → re-dispatch release-node.yml (dry-run→real) to publish node rc.3. Closes AAASM-4067.

🤖 Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant