Skip to content

[AAASM-4062] 🐛 (node-sdk): Fix brew install command (wrong org)#229

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4062/fix/homebrew_tap_command
Jul 4, 2026
Merged

[AAASM-4062] 🐛 (node-sdk): Fix brew install command (wrong org)#229
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4062/fix/homebrew_tap_command

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Target

  • Task summary:

    Fix the Homebrew install hint printed when the aasm runtime binary is not
    found. It was missing the ai- org prefix, pointing users at a 404.

  • Task tickets:

    • Task ID: AAASM-4062.
    • Relative task IDs:
      • AAASM-4060 (parent bug).
    • Relative PRs:
      • N/A.
  • Key point change (optional):

    src/runtime.ts INSTALL_HINT:

    • As-is: brew install agent-assembly/tap/aasm — Homebrew resolves this to
      github.com/agent-assembly/homebrew-tap, which does not exist → 404.
    • To-be: brew install ai-agent-assembly/tap/aasm — resolves to the
      canonical github.com/ai-agent-assembly/homebrew-tap tap.

Effecting Scope

  • Action Types:
    • ✨ Adding new something
      • 🟢 No breaking change
      • 🟠 Has breaking change
    • ✏️ Modifying existing something
      • 🟢 No breaking change
      • 🟠 Has breaking change
    • 🚮 Removing something
    • 🔧 Fixing bug
      • 🟢 No breaking change
    • ♻️ Refactoring something
    • 🍀 Improving something (performance, code quality, security, etc.)
    • 🚀 Release
  • Scopes:
    • 🧩 SDK public API
    • 🪡 API client and transport
    • 🤖 Framework hooks
    • 🫀 Data model and types
    • ⛑️ Error handling
    • 🧪 Testing
      • 🧪 Unit testing
      • 🧪 Integration testing
      • 🧪 End-to-end testing
    • 🚀 Building
      • 🤖 CI/CD
      • 🔗 Dependencies
      • 📦 Project configurations
    • 📚 Documentation
  • Additional description:
    User-facing install instruction only; no code path or public API changes.

Description

  • One-line fix in src/runtime.ts: correct the brew install command in the
    INSTALL_HINT string from agent-assembly/tap/aasm to
    ai-agent-assembly/tap/aasm (the canonical org).
  • Root cause: the missing ai- org prefix made Homebrew look up
    github.com/agent-assembly/homebrew-tap, a non-existent repo → 404 on
    brew install.
  • Validation: grep confirms zero remaining bare agent-assembly/tap
    references (all now ai-agent-assembly/tap) and no ai-ai- doubling. A full
    tsc --noEmit typecheck was skipped because dependencies are not installed
    and installing them requires network access (unavailable); the change is a
    single string-literal edit and the surrounding file is unchanged.

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

✅ Claude Code review — AAASM-4062

1. CI: Green — all test (20/22/24 × ubuntu/macos/windows), CodeQL, SonarCloud, audit pass.
2. Scope: Covers the subtask — the single src/runtime.ts:41 INSTALL_HINT string now ai-agent-assembly/tap/aasm. Grep: 0 residual.
3. Side effects: None. One string literal in an error hint; no logic change. Fixes a hard-404 command.
4. Front-end: N/A — SDK runtime string, no browser/UI code.

Verdict: ready to approve + merge (BLOCKED = awaiting required approval). — Claude Code

@Chisanan232 Chisanan232 merged commit 5d97740 into master Jul 4, 2026
25 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-4062/fix/homebrew_tap_command branch July 4, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant