[AAASM-4062] 🐛 (node-sdk): Fix brew install command (wrong org)#229
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Contributor
Author
✅ Claude Code review — AAASM-40621. CI: Green — all Verdict: ready to approve + merge (BLOCKED = awaiting required approval). — Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Target
Task summary:
Fix the Homebrew install hint printed when the
aasmruntime binary is notfound. It was missing the
ai-org prefix, pointing users at a 404.Task tickets:
Key point change (optional):
src/runtime.tsINSTALL_HINT:brew install agent-assembly/tap/aasm— Homebrew resolves this togithub.com/agent-assembly/homebrew-tap, which does not exist → 404.brew install ai-agent-assembly/tap/aasm— resolves to thecanonical
github.com/ai-agent-assembly/homebrew-taptap.Effecting Scope
User-facing install instruction only; no code path or public API changes.
Description
src/runtime.ts: correct thebrew installcommand in theINSTALL_HINTstring fromagent-assembly/tap/aasmtoai-agent-assembly/tap/aasm(the canonical org).ai-org prefix made Homebrew look upgithub.com/agent-assembly/homebrew-tap, a non-existent repo → 404 onbrew install.agent-assembly/tapreferences (all now
ai-agent-assembly/tap) and noai-ai-doubling. A fulltsc --noEmittypecheck was skipped because dependencies are not installedand installing them requires network access (unavailable); the change is a
single string-literal edit and the surrounding file is unchanged.