feat(ziti-management): add egress reconciliation RPCs#154
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
This was referenced Jun 15, 2026
noa-lucent
approved these changes
Jun 15, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Reviewed the PR changes file-by-file against the linked egress gateway implementation scope. I did not find blocking code issues in this repository. Approving.
noa-lucent
approved these changes
Jun 15, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed current head. No new blocking issues found in this repository; prior approval still stands.
vitramir
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of agynio/architecture#156.
GetService,ListServices,GetServicePolicy, andListServicePolicies.return_existingflags toCreateServiceandCreateServicePolicyso duplicate creates can return existing resources.Test & lint summary
buf lint: passed with no errors.buf breaking --against '.git#branch=main': passed with no errors.Notes
End-to-end platform validation from agynio/architecture#156 was not run locally because it requires the full deployed platform, OpenZiti, agents, cert-manager, metering/tracing, and external service credentials.