feat(egress): add gateway proto contracts#144
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & Lint SummaryCommands run locally:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Found two blocking API-shape issues: the egress rule and attachment public response messages expose OpenZiti implementation IDs that the architecture marks as internal and not returned through the Gateway. Please adjust the public/internal DTO split before merge.
Update: internal-only egress fieldsAddressed Noa's requested change:
Test & Lint SummaryCommands run locally:
Results:
|
|
Ready for Noa re-review. I pushed a follow-up fix that removes the OpenZiti implementation identifiers from the PR diff entirely:
Verification:
Test & Lint SummaryCommands run locally:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The OpenZiti implementation IDs have been removed from the public egress rule and attachment messages, and the previous threads are resolved. The updated proto surface matches the Phase 1 API contract.
|
Noa approved and buf checks are green. Ready to merge when a maintainer is available. |
|
Architecture update (agynio/architecture commit af3940d) removes per-workload NetworkPolicy and runner CIDR fields. This PR currently includes runner network_policy + cluster_*_cidr additions; those parts need to be removed/adjusted to match updated docs. Leaving this comment for tracking; will follow up with a patch in this PR. |
|
Updated PR 144 for architecture commit Changes pushed:
Verification:
Test & Lint SummaryCommands run locally:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
The network_policy and runner CIDR removals are aligned with architecture commit af3940d, but the update also removed the per-container inline file mount selector. The architecture still defines inline files as per-container, so the runner contract needs that field restored while keeping NetworkPolicy/CIDR fields out.
|
Updated PR 144 for Noa's latest review. Changes pushed:
Verification:
Test & Lint SummaryCommands run locally:
Results:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The per-container inline file mount selector has been restored, while the per-workload NetworkPolicy and runner CIDR fields remain removed. Previous feedback is resolved and CI is green.
|
Status: updated per architecture af3940d (no per-workload NetworkPolicy), restored per-container inline file mounts. Noa approved and buf checks are green. Ready for maintainer merge. |
|
Ping: PR is approved (Noa) + buf green and aligned with architecture update (af3940d). Merge is still blocked by branch policy from my account. Requesting a maintainer merge when available. |
Summary
agynio.api.egress.v1proto contracts for egress rules, rule matchers/effects/header injection, attachments, external CRUD, and internal lookup/reference-check RPCs.EgressRulesGatewayfacade proto for the externally exposed methods only.StartWorkloadRequest.inline_files, and workloadNetworkPolicy.ResolveSecretExistsRPC required by the egress gateway v1 architecture.Repo discovery
agynio/apiagynio/gatewayCloses #143
Validation
buf buildbuf lintbuf breaking --against '.git#branch=main'git diff --check