[codex] Fix Android PWA installability#98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Android Chrome could load the manifest and icons, but a fresh hosted/static app visit did not register
/t3-service-worker.jsbecausePwaRuntimereturnednulluntilusePrimaryEnvironmentId()produced an environment. That left Chrome with no service-worker registration on the install page.Validation
vp run --filter @t3tools/web test -- src/pwa/pwaRuntime.test.ts src/t3ServiceWorker.test.ts(web unit runner matched full web suite: 165 files / 1500 tests)vp run --filter @t3tools/web build/usr/bin/google-chrome+playwright-coreagainstvp previewverified manifest served withname,short_name,start_url,display: standalone; 192x192 and 512x512 PNG icons plus maskable 512 icon; and one active service-worker registration at/t3-service-worker.js.vp check(passes; reports pre-existing mobile unused-symbol warnings)vp run typecheck