Skip to content

[codex] Fix Android PWA installability#98

Merged
adamfgr merged 1 commit into
mainfrom
wizzo/pwa-install-fix
Jul 6, 2026
Merged

[codex] Fix Android PWA installability#98
adamfgr merged 1 commit into
mainfrom
wizzo/pwa-install-fix

Conversation

@wizzoapp

@wizzoapp wizzoapp Bot commented Jul 6, 2026

Copy link
Copy Markdown

What changed

  • Register the web app service worker as part of the PWA shell, even before a primary environment exists.
  • Keep push-notification device registration and environment-specific side effects gated on an environment.
  • Add a PWA runtime shape test covering the no-environment install path.

Root cause

Android Chrome could load the manifest and icons, but a fresh hosted/static app visit did not register /t3-service-worker.js because PwaRuntime returned null until usePrimaryEnvironmentId() produced an environment. That left Chrome with no service-worker registration on the install page.

Validation

  • vp run --filter @t3tools/web test -- src/pwa/pwaRuntime.test.ts src/t3ServiceWorker.test.ts (web unit runner matched full web suite: 165 files / 1500 tests)
  • vp run --filter @t3tools/web build
  • Headless /usr/bin/google-chrome + playwright-core against vp preview verified manifest served with name, short_name, start_url, display: standalone; 192x192 and 512x512 PNG icons plus maskable 512 icon; and one active service-worker registration at /t3-service-worker.js.
  • vp check (passes; reports pre-existing mobile unused-symbol warnings)
  • vp run typecheck
  • Factory pre-commit gate: PASS, including Codex gpt-5.5 autoreview clean

@wizzoapp wizzoapp Bot marked this pull request as ready for review July 6, 2026 21:09
@wizzoapp wizzoapp Bot marked this pull request as draft July 6, 2026 21:22
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 6, 2026 21:22

@adamfgr adamfgr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by wizzo-approve: all policy conditions verified against HEAD 35040d5.

@adamfgr adamfgr added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 55eb5e4 Jul 6, 2026
12 checks passed
@adamfgr adamfgr deleted the wizzo/pwa-install-fix branch July 6, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant