Skip to content

Fix desktop Cloudflare Access remote connections#90

Merged
adamfgr merged 2 commits into
mainfrom
codex/desktop-cfaccess-fix
Jul 6, 2026
Merged

Fix desktop Cloudflare Access remote connections#90
adamfgr merged 2 commits into
mainfrom
codex/desktop-cfaccess-fix

Conversation

@wizzoapp

@wizzoapp wizzoapp Bot commented Jul 6, 2026

Copy link
Copy Markdown

Summary

  • keep desktop Cloudflare Access interactive sign-in alive when Electron reports redirect-class loadURL interruptions while navigating to the Access login page
  • preserve Cloudflare Access JWT/service-token fields from pairing URL fragments and explicit Add Environment fields
  • install/clear Cloudflare Access transport credentials through the desktop IPC layer so HTTP, WebSocket ticketing, SSE, and socket handshakes use the intended credential without stale header/cookie bleed

Proof

  • Factory gate on 1ce9f4322: vp run typecheck, vp check, Codex gpt-5.5 autoreview clean
  • Focused tests: desktop Cloudflare Access IPC, shared remote URL parsing, client-runtime onboarding/resolver, web settings parser
  • Local launch proof: final built staged app launched under Xvfb via repo Electron and passed scripts/desktop-launch-smoke.mjs
  • Cloudflare Access redirect proof: final built app invoked window.desktopBridge.authenticateCloudflareAccess({ host: "https://oc.agriffiths.dev/" }), auth renderer reached https://agriffiths.cloudflareaccess.com/cdn-cgi/access/login/..., and IPC state stayed pending
  • Superseded PR Fix desktop Cloudflare Access remote connections #86 CI on the same head passed: Check, Test, Release Smoke, Desktop Linux Package Smoke, Desktop Windows Package Smoke

Notes

  • Supersedes Fix desktop Cloudflare Access remote connections #86 because Codex review stopped attaching to fresh pushes on that PR after multiple review cycles.
  • Local Linux electron-builder --target dir hung twice after writing only the raw Electron runtime; the real packaged artifact gate is covered by CI Linux/Windows package smoke.

@wizzoapp wizzoapp Bot marked this pull request as ready for review July 6, 2026 15:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ce9f43224

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/client-runtime/src/connection/resolver.ts
@wizzoapp wizzoapp Bot marked this pull request as draft July 6, 2026 15:25
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 6, 2026 15:25

@adamfgr adamfgr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by wizzo-approve: all policy conditions verified against HEAD 1564755.

@adamfgr adamfgr enabled auto-merge July 6, 2026 15:47
@adamfgr adamfgr added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 2f1327f Jul 6, 2026
13 checks passed
@adamfgr adamfgr deleted the codex/desktop-cfaccess-fix branch July 6, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant