fix(web): preserve desktop notification hash links (ADA-50)#77
Merged
Conversation
wizzoapp
Bot
force-pushed
the
ada50-deeplink
branch
from
c2beb25 to
bc2414b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADA-50.
Summary
createBrowserHistory().#/...) used bycreateHashHistory()inapps/web/src/main.tsx.Repro / verification
main.tsxselectscreateHashHistory()under Electron while the pre-fixopenDeepLink()assigned the raw pathname.vp test run apps/web/src/pwa/pwaRuntime.test.ts.vp check --fix,vp run typecheck, andvp run build:desktop.