fix(examples): use raw DashScope model name#2318
Open
huangxian119 wants to merge 4 commits into
Open
Conversation
|
xianhuang2 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
CLA Not Signed The Contributor License Agreement (CLA) check is currently pending on this PR ( @huangxian119 please sign the CLA via the CLA assistant badge in the comment above, or visit https://cla-assistant.io/agentscope-ai/agentscope-java. Once signed, the Automated check by github-manager-bot |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeContextExampleto pass the raw DashScope API model nameqwen-pluswhen constructingDashScopeChatModeldirectly.dashscope:qwen-plusform forModelRegistry-based configuration.Root cause
dashscope:qwen-plusis a ModelRegistry identifier, not a DashScope API model name. Sending it directly to DashScope returns HTTP 400 withInvalidParameter: Model not exist.Test plan
JAVA_HOME=<JDK 17> mvn -pl agentscope-examples/documentation -am -Dtest=RuntimeContextExampleTest -DfailIfNoTests=false testJAVA_HOME=<JDK 17> mvn -pl agentscope-examples/documentation -am -DskipTests compile