Skip to content

fix(examples): correct skill example resource path#2250

Merged
jujn merged 1 commit into
agentscope-ai:mainfrom
xiaoyuuuuuupeng:codex/fix-skill-example-path
Jul 16, 2026
Merged

fix(examples): correct skill example resource path#2250
jujn merged 1 commit into
agentscope-ai:mainfrom
xiaoyuuuuuupeng:codex/fix-skill-example-path

Conversation

@xiaoyuuuuuupeng

Copy link
Copy Markdown
Contributor

AgentScope-Java Version

2.0.1-SNAPSHOT

Description

Correct the skills resource path in AgentSkillExample after the documentation example directory reorganization. The example now points to the existing agentscope-examples/documentation/src/main/resources/skills directory.

Validation:

  • mvn -pl agentscope-examples/documentation -am compile -DskipTests -Dspotless.check.skip=true -q
  • git diff --cached --check

Note: the reactor-wide Spotless check is currently blocked by pre-existing CRLF formatting violations in 104 files under agentscope-core; the changed file itself has no formatting violations.

Checklist

  • Code has been checked for formatting
  • Relevant module compiles successfully
  • Javadoc comments are complete and follow project conventions
  • Related documentation/examples have been updated
  • Code is ready for review

@CLAassistant

CLAassistant commented Jul 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AgentScopeJavaBot AgentScopeJavaBot added bug Something isn't working area/examples agentscope-examples labels Jul 16, 2026

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

This PR fixes the SKILLS_DIR resource path in AgentSkillExample — removes the non-existent quickstart/ intermediate directory segment, aligning it with the post-reorganization Maven module structure (agentscope-examples/documentation/). The change is minimal (+1/-1) and the fix direction is correct. The actual skills resource directory does exist at the corrected path. However, the symmetric path OUTPUT_DIR has the same class of bug unfixed.

Recommendation: COMMENT

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

This PR fixes the SKILLS_DIR resource path in AgentSkillExample — removes the non-existent quickstart/ intermediate directory segment, aligning it with the post-reorganization Maven module structure (agentscope-examples/documentation/). The change is minimal (+1/-1) and the fix direction is correct. The actual skills resource directory does exist at the corrected path. However, the symmetric path OUTPUT_DIR has the same class of bug unfixed.

Recommendation: COMMENT

@jujn jujn merged commit a0c147a into agentscope-ai:main Jul 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/examples agentscope-examples bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants