Feat/local filesystem shared read prefixes#2245
Conversation
- 移除 AgentCatalogService 中不再使用的 ToolEventBus 依赖 - 在 BuilderBootstrap 中添加全局配置器支持动态代理配置 - 实现 LocalFilesystemSpec 的共享前缀功能,支持多租户环境下的文件共享 - 添加 shared-read-prefixes 配置选项用于定义共享只读目录 - 创建 SharedPrefixUtils 工具类处理共享目录前缀标准化 - 添加 LocalFilesystemSpecSharedPrefixTest 测试验证共享功能 - 更新 README.md 文档说明共享只读工作目录的使用方法 - 优化动态代理创建过程以复用全局配置包括文件系统和中间件设置
- 在 LocalFilesystemSpec 中新增 isolationScope 和 addSharedPrefix 配置选项 - 支持按用户隔离的共享只读基线目录覆盖功能 - 新增 sharedPrefixes 方法用于批量设置共享目录 - 更新文档说明共享前缀的工作原理和目录结构 - 修改 IsolationScope 注释以包含本地共享前缀语义 - 优化远程和本地文件系统的隔离范围定义一致性
|
@jujn 你好,这个CI失败看起来是JUnit清理测试上下文时的偶发问题,我在本地测试可以正常通过。我好像没有重新运行CI的权限,能否麻烦帮忙重跑一下,谢谢! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@jujn 目前所有 CI 检查均已通过。麻烦您有空时帮忙审阅一下,非常感谢!🙏 |
最近任务比较多。可能会稍晚一些哈。 |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR adds shared read prefix (shared directory) support to LocalFilesystemSpec, aligning it with the existing RemoteFilesystemSpec semantics. The implementation uses a CompositeFilesystem + OverlayFilesystem layered routing architecture: each shared prefix maps to a LocalRouteOverlay route (upper layer = tenant CoW overlay, lower layer = shared read-only source), with LocalCompositeFilesystem handling route dispatch while preserving shell execution. The BuilderBootstrap cross-cutting configuration propagation was also refactored (configureDynamicAgent) so dynamically created user-defined agents get consistent filesystem/middleware config. Addresses issue #2244 with a complete implementation of all expected behaviors.
Recommendation: COMMENT
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR adds shared read prefix (shared directory) support to LocalFilesystemSpec, aligning it with the existing RemoteFilesystemSpec semantics. The implementation uses a CompositeFilesystem + OverlayFilesystem layered routing architecture: each shared prefix maps to a LocalRouteOverlay route (upper layer = tenant CoW overlay, lower layer = shared read-only source), with LocalCompositeFilesystem handling route dispatch while preserving shell execution. The BuilderBootstrap cross-cutting configuration propagation was also refactored (configureDynamicAgent) so dynamically created user-defined agents get consistent filesystem/middleware config. Addresses issue #2244 with a complete implementation of all expected behaviors.
Recommendation: COMMENT
- 为 localOverlayRoute 方法添加详细的构建副本写入视图说明 - 为 LocalRouteOverlay 类添加完整的复制写入覆盖功能描述 - 补充 LocalRouteOverlay 构造函数的参数说明文档 - 优化 AgentCatalogService 中动态代理配置调用顺序的注释说明 - 完善 BuilderBootstrap.configureDynamicAgent 方法的调用时机文档
|
已针对复杂逻辑补充设计注释: |
Close #2244
期望行为
为
LocalFilesystemSpec增加共享目录前缀配置,并与 Remote 模式保持一致的语义:IsolationScope隔离。验收标准
..等路径穿越配置。