fix: narrow bare except Exception in version fallback (import of github/spec-kit#3835) - #124
Open
one-kash wants to merge 1 commit into
Open
fix: narrow bare except Exception in version fallback (import of github/spec-kit#3835)#124one-kash wants to merge 1 commit into
one-kash wants to merge 1 commit into
Conversation
Replace overly broad except Exception with specific exception types: - importlib.metadata.PackageNotFoundError for missing package - (OSError, KeyError, ValueError) for pyproject.toml read/parse errors This prevents silently swallowing unexpected errors like AttributeError or RecursionError from broken tomllib or malformed pyproject.toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from upstream PR github#3835
Original author: @Quratulain-bilal
Original head branch:
fix/assets-narrow-exceptionSummary
Replace overly broad
except Exceptionwith specific exception types inget_speckit_version()fallback.Changes
_assets.py: Narrow outer exception toPackageNotFoundError_assets.py: Narrow inner exception to(OSError, KeyError, ValueError)