build(server): build publishable wheels via build script#217
Draft
abhinav-galileo wants to merge 1 commit intomainfrom
Draft
build(server): build publishable wheels via build script#217abhinav-galileo wants to merge 1 commit intomainfrom
abhinav-galileo wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The `build-server` and `build-sdk` Make targets ran a raw `uv build`
in the package directory. Both packages declare `agent_control_models`,
`agent_control_engine`, and `agent_control_telemetry` as vendored
packages in their hatch wheel config. Without the pre-build copy that
`scripts/build.py` performs, hatch silently produces a wheel whose
declared package directories are empty on disk:
$ unzip -l dist/agent_control_server-*.whl | grep telemetry/
(no match)
The resulting wheel installs cleanly via pip but crashes at startup
because the bundled imports are missing:
agent-control-migrate: No module named 'agent_control_telemetry'
Delegate `build-models`, `build-server`, and `build-sdk` to the
canonical `scripts/build.py` entry points so that `make build-server`
and `make build-sdk` produce the same wheels as the publish pipeline
runs in CI. Verified: rebuilt wheels now contain
`agent_control_models`, `agent_control_engine`, and
`agent_control_telemetry` under their respective package directories.
`build-models` had no vendored packages, so the previous raw-`uv build`
worked, but routing it through the script keeps the build-target
shape uniform across the three publishable packages.
abhinav-galileo
changed the title
abhinav-galileo
force-pushed
the
abhi/fix-make-build-script-delegation
branch
from
7647bda to
35c19fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/build.py.Testing
make prepush