Expose Codex subagent activity over ACP#304
Merged
anna239 merged 1 commit intoJul 15, 2026
Merged
Conversation
Map subAgentActivity notifications to standard ACP tool calls with namespaced Codex metadata. Preserve collaboration model metadata and replay the same events when loading session history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subAgentActivityitems to standard ACPtool_callupdates_meta.codex.subagentmetadata_meta.codex.collaborationRationale
Real Codex app-server runs report a spawn as a completed
subAgentActivityitem rather than acollabAgentToolCall(spawnAgent). The adapter currently ignores that item, so ACP clients only see subsequentwaitcollaboration calls. ACP v1 has no dedicated subagent update or tool kind, so this uses the spec-compatibletool_call(kind: other)representation and the reserved namespaced_metaextension point.Child-thread messages and tools are intentionally not forwarded into the parent ACP session in this change. Doing that safely requires explicit client capability negotiation so clients that do not understand parent metadata do not render child events at the top level.
Verification
npm run typechecknpm test(311 passed, 28 skipped)npm run buildnpm run codex-testto verify the emittedsubAgentActivityshape