Improve request_user_input elicitation forms#299
Open
OldKrab wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the ACP form emitted for Codex
request_user_inputand align its custom-answer behavior with the native Codex CLI.ACP request structure
For each question:
questionas the propertytitle.headeras the propertydescription.requiredarray.For questions where
isOtheris true and the options list is non-empty:None of the abovetooneOf, matching the option that Codex CLI adds under the same condition.<question_id>__otherproperty with<question_id>_note. The note is modeled as additional input associated with the selected option rather than as a replacement for that option._meta.codex.role: user_noteinstead ofisOtherAnswer: true.The top-level elicitation message is now the stable
Codex needs your input to continue.text.ACP response mapping
Codex CLI preserves the selected option and appends a non-empty note as a separate
user_note: <text>answer. This adapter now returns the ACP form response in that same Codex-compatible shape instead of replacing the selected option with the custom text.For example, selecting
None of the aboveand entering a custom answer produces:{ "answers": { "<question_id>": { "answers": [ "None of the above", "user_note: <custom answer>" ] } } }The
<question_id>_noteproperty is the ACP form representation used to collect the note. TheNone of the aboveoption and the returned selection-plus-note answer list mirror Codex CLI behavior.