fix(history): strip binary image blobs from chat.json serialization#1226
Open
vanja-emichi wants to merge 1 commit intoagent0ai:developmentfrom
Open
fix(history): strip binary image blobs from chat.json serialization#1226vanja-emichi wants to merge 1 commit intoagent0ai:developmentfrom
vanja-emichi wants to merge 1 commit intoagent0ai:developmentfrom
Conversation
RawMessage content (base64-encoded images) was being written verbatim to chat.json during disk serialization. This caused two problems: 1. chat.json bloated to MBs after any image-containing conversation 2. Reloaded chats would re-send the full image blob to the LLM on every subsequent call, inflating token usage and context size. Fix: detect RawMessage content in Message.to_dict() and replace it with the preview text (if present) or a placeholder string before persisting. Binary blobs are ephemeral — they are only valid for the current LLM session and should never be stored on disk. Co-authored-by: BMad Master <bmad@agent-zero>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RawMessage content (base64-encoded images) was being written verbatim to chat.json during disk serialization. This caused two problems:
Fix: detect RawMessage content in Message.to_dict() and replace it with the preview text (if present) or a placeholder string before persisting. Binary blobs are ephemeral — they are only valid for the current LLM session and should never be stored on disk.