Add ResourceMetadata to both actor and atespace resources.#409
Merged
Conversation
| atespace := &ateapipb.Atespace{ | ||
| Metadata: &ateapipb.ResourceMetadata{Name: req.GetName()}, | ||
| } | ||
| stored, err := s.persistence.CreateAtespace(ctx, atespace) |
Collaborator
There was a problem hiding this comment.
nit: storedAtespace, like storedActor in create_actor.go.
Collaborator
There was a problem hiding this comment.
Or both use stored as I saw in update_actor.go there's just updated.
Collaborator
Author
There was a problem hiding this comment.
Done
| // metadata.atespace is always empty; the atespace's identity is metadata.name. | ||
| message Atespace { | ||
| string name = 1; | ||
| // Common resource metadata: uid, version, timestamps. |
Collaborator
There was a problem hiding this comment.
nit: missing name before uid?
Collaborator
Author
There was a problem hiding this comment.
Done.
Replace actor_id and atespace name with `metadata` field which holds common fields. This commit only changes the ate-apiserver to support this field, but intentionally skips upstream / downstream systems (such as kubectl-ate, atenet, atelet, etc) to keep the scope manageable. This will come in subsequent PRs.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
api_alignment
branch
from
27b4c7c to
cb04833
Compare
Haven Xia (HavenXia)
approved these changes
Jul 8, 2026
Haven Xia (HavenXia)
merged commit af1f005
into
agent-substrate:main
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace actor_id and atespace name with
metadatafield which holds common fields.This commit only changes the ate-apiserver to support this field, but intentionally skips upstream / downstream systems (such as kubectl-ate, atenet, atelet, etc) to keep the scope manageable. This will come in subsequent PRs.
Subsequent PRs will rework Create/Update/Delete/List methods to align with the style guide (validations, preconditions, etc).
#149