POC: pluggable ingress for substrate#393
Draft
Jet Chiang (supreme-gg-gg) wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> agentgateway Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> extproc docs Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> revised: docs and manifests Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> revised: docs and manifests Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> remove default envoy and scripts Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> cleanup a bit Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> cleanup old files from main Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
| @@ -0,0 +1,84 @@ | |||
| // Copyright 2026 Google LLC | |||
Collaborator
There was a problem hiding this comment.
Is there a reason why some of the files were renamed? I'm not against refactoring, but if you can keep the meaningful changes to a minimal set. If we rename files, ideally you would contain that in its own commit.
Contributor
Author
There was a problem hiding this comment.
I don't think they were renamed, at least not literally. The motivation here is to move from Envoy specific type (which was in errors.go) to a protocol neutral interface in route.go, route_resolve.go, route_errors.go, and that's why some old files are replaced by new ones. If there's any ways to simplify the refactor that you would suggest I'm glad to do that
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for #326, based on the design in https://docs.google.com/document/d/1djurA9d7f7UIW2DhSqyX85Ad8JgkpPPyCbpDy7G7HOs/edit?tab=t.r12pfwjkq9tf#heading=h.68j4yb47rvbt
Key Changes
manifests/ate-install/atenet-router.yamlis the single (extproc-only) router manifesthack/install-ate.shdeploys the basic reference Envoy gateway alongside the router by default, tests are updated