Move WorkerPoolSyncer to ate-controller - #1203
Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits intoAug 26, 2026
Merged
Conversation
sfunkenhauser
force-pushed
the
worker_pool_syncer_migrate
branch
3 times, most recently
from
August 25, 2026 19:36
fe23b1a to
a599098
Compare
sfunkenhauser
marked this pull request as ready for review
August 25, 2026 20:25
| // | ||
| // A concurrent SuspendActor or ResumeActor wins the optimistic version check; | ||
| // this attempt fails as ABORTED so the caller retries against the newer state. | ||
| func (s *RPCService) releaseActorOnDeadWorker(ctx context.Context, worker *ateapipb.Worker) error { |
Collaborator
There was a problem hiding this comment.
Should we move this into a DeleteWorker workflow? That would be consistent with other RPC handlers that need to orchestrate an idempotent sequence of steps.
sfunkenhauser
force-pushed
the
worker_pool_syncer_migrate
branch
from
August 26, 2026 14:52
a599098 to
68deb82
Compare
sfunkenhauser
force-pushed
the
worker_pool_syncer_migrate
branch
from
August 26, 2026 15:11
68deb82 to
08c59b0
Compare
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 26, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 26, 2026
37735a6
into
agent-substrate:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729