ateom-microvm: tear down the guest when checkpoint fails after pause - #1159
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Open
Conversation
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/checkpoint-teardown-on-failure
branch
from
August 26, 2026 07:13
8c5a8c5 to
3105334
Compare
Once client.Pause succeeds, every later failure (checkpoint dir setup, the concurrent snapshot/tar capture, listing snapshot files) returned early without tearing the guest down. The guest was left paused with nothing watching it and s.running still pointed at it, so it stayed stuck until a manual node restart.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/checkpoint-teardown-on-failure
branch
from
August 26, 2026 15:42
3105334 to
71f60bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the guest is paused in CheckpointWorkload, any later failure (checkpoint dir setup, the concurrent snapshot/tar capture, listing snapshot files) returned early without tearing the guest down. The guest stayed paused with nothing watching it and s.running still pointed at it, leaving the actor stuck until a manual node restart. This tears the guest down on any failure after pause, the same way the success path already does.