Skip to content

Compartmentalize AtespaceExists() #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tim Hockin (thockin) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compartmentalize AtespaceExists() #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/ateapi/internal/actoridentity/actoridentity_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,14 @@ func seedActor(t *testing.T, ctx context.Context, st store.Interface, f actorFix
t.Helper()

actorRef := resources.ActorRef{Atespace: testAtespace, Name: testActorName}

atespace := &ateapipb.Atespace{
Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace},
}
if _, err := st.CreateAtespace(ctx, atespace); err != nil {
t.Fatalf("seed atespace: %v", err)
}

actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: actorRef.Atespace, Name: actorRef.Name},
Status: &ateapipb.ActorStatus{State: f.state},
Expand Down
9 changes: 0 additions & 9 deletions cmd/ateapi/internal/controlapi/actor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,6 @@ func (s *Service) CreateActor(ctx context.Context, req *ateapipb.CreateActorRequ
atespace := in.GetMetadata().GetAtespace()
name := in.GetMetadata().GetName()

// The atespace must already exist.
exists, err := s.persistence.AtespaceExists(ctx, atespace)
if err != nil {
return nil, fmt.Errorf("while checking atespace: %w", err)
}
if !exists {
return nil, status.Errorf(codes.FailedPrecondition, "Atespace %s not found", atespace)
}

// Volume creation is completed asynchronously after the actor is recorded.
initVols, err := initialActorVolumes(ctx, s.storageClassLister, template)
if err != nil {
Expand Down
8 changes: 0 additions & 8 deletions cmd/ateapi/internal/controlapi/actor_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ func (s *Service) CreateActorTemplate(ctx context.Context, req *ateapipb.CreateA
in := req.GetActorTemplate()
templateRef := resources.ActorTemplateRefFromActorTemplate(in)

exists, err := s.persistence.AtespaceExists(ctx, templateRef.Atespace)
if err != nil {
return nil, fmt.Errorf("while checking atespace: %w", err)
}
if !exists {
return nil, status.Errorf(codes.FailedPrecondition, "Atespace %s not found", templateRef.Atespace)
}

// Rebuild the template from the client-owned fields only: status is
// server-owned and ignored per the CreateActorTemplateRequest contract.
template := &ateapipb.ActorTemplate{
Expand Down
17 changes: 17 additions & 0 deletions cmd/ateapi/internal/controlapi/actor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,11 @@ func TestUpdateActor_DeleteRecreateRace(t *testing.T) {

actorRef := resources.ActorRef{Atespace: testAtespace, Name: testActorID}

atespace := &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}
if _, err := persistence.CreateAtespace(ctx, atespace); err != nil {
t.Fatalf("seed CreateAtespace: %v", err)
}

// Actor A: what the client reads, and what its uid precondition names.
// Freshly created, so it sits at version 1.
original, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Expand Down Expand Up @@ -478,6 +483,10 @@ func TestUpdateActor_ConcurrentDisjointUpdates(t *testing.T) {

actorRef := resources.ActorRef{Atespace: testAtespace, Name: testActorID}

atespace := &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}
if _, err := persistence.CreateAtespace(ctx, atespace); err != nil {
t.Fatalf("seed CreateAtespace: %v", err)
}
original, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: testAtespace, Name: testActorID},
ActorTemplateNamespace: "ns1",
Expand Down Expand Up @@ -568,6 +577,14 @@ func serviceWithActor(t *testing.T, actor *ateapipb.Actor) (*Service, *ateapipb.
persistence, cleanup := storetest.SetupTestStore(t)
t.Cleanup(cleanup)

atespace := &ateapipb.Atespace{
Metadata: &ateapipb.ResourceMetadata{Name: actor.Metadata.Atespace},
}
_, err := persistence.CreateAtespace(context.Background(), atespace)
if err != nil {
t.Fatalf("Failed to CreateAtespace: %v", err)
}

created, err := persistence.CreateActor(context.Background(), actor)
if err != nil {
t.Fatalf("Failed to CreateActor: %v", err)
Expand Down
12 changes: 12 additions & 0 deletions cmd/ateapi/internal/controlapi/crash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ import (
// tests can assert they are cleared when the actor crashes.
func seedActor(t *testing.T, ctx context.Context, st store.Interface, actorRef resources.ActorRef) {
t.Helper()

atespace := &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}
if _, err := st.CreateAtespace(ctx, atespace); err != nil {
t.Fatalf("Failed to CreateAtespace: %v", err)
}

if _, err := st.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Name, Atespace: actorRef.Atespace},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -90,6 +96,9 @@ func seedWorker(t *testing.T, ctx context.Context, st store.Interface, actorRef
// already cleared, e.g. by a prior release.
func seedUnboundActor(t *testing.T, ctx context.Context, st store.Interface, actorRef resources.ActorRef) {
t.Helper()
if _, err := st.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
if _, err := st.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Name, Atespace: actorRef.Atespace},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -458,6 +467,9 @@ func TestCrashActor_Metrics(t *testing.T) {
},
},
}
if _, err := st.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actor.Metadata.Atespace}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
if _, err := st.CreateActor(ctx, actor); err != nil {
t.Fatalf("CreateActor: %v", err)
}
Expand Down
1 change: 0 additions & 1 deletion cmd/ateapi/internal/controlapi/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ type serviceStore interface {
GetActorSnapshotTag(ctx context.Context, atespace, name string) (*ateapipb.ActorSnapshotTag, error)
UpdateActorSnapshotTag(ctx context.Context, atespace, name string, precondition store.Precondition, mutate func(toUpdate *ateapipb.ActorSnapshotTag) error) (*ateapipb.ActorSnapshotTag, error)
DeleteActorSnapshotTag(ctx context.Context, atespace, name string) (*ateapipb.ActorSnapshotTag, error)
AtespaceExists(ctx context.Context, name string) (bool, error)
CreateAtespace(ctx context.Context, atespace *ateapipb.Atespace) (*ateapipb.Atespace, error)
GetAtespace(ctx context.Context, name string) (*ateapipb.Atespace, error)
ListAtespaces(ctx context.Context, opts store.ListOptions) (store.ListResponse[*ateapipb.Atespace], error)
Expand Down
23 changes: 23 additions & 0 deletions cmd/ateapi/internal/controlapi/syncer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@ func TestSyncer_DeleteBoundWorker_ClearsActor(t *testing.T) {
t.Fatalf("worker row not materialised: %v", err)
}
actorName := "actor-orphan"
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-orphan"}}); err != nil {
t.Fatalf("create atespace: %v", err)
}
createdActor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorName, Atespace: "team-orphan"}, ActorTemplateNamespace: ns, ActorTemplateName: "tmpl",
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -582,6 +585,11 @@ func TestReconcileDeadWorker(t *testing.T) {

ns, pool, pod := "ns-rdw", "pool1", "worker-rdw"
atespace, actorID := "team-rdw", "actor-rdw"

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

createdActor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorID, Atespace: atespace}, ActorTemplateNamespace: ns, ActorTemplateName: "tmpl",
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -637,6 +645,11 @@ func TestReconcileDeadWorker_IgnoresStaleIncarnationAssignment(t *testing.T) {

ns, pool, pod, uid := "ns-rdw", "pool1", "worker-rdw", "uid-rdw"
atespace, actorID := "team-rdw", "actor-rdw"

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

createdActor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorID, Atespace: atespace}, ActorTemplateNamespace: ns, ActorTemplateName: "tmpl",
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -729,6 +742,11 @@ func TestSyncer_ReconcileOrphanedWorkers(t *testing.T) {
// An orphan worker (no pod) whose actor is still RUNNING must be cleaned up.
const orphanUID = "22222222-2222-2222-2222-222222222222"
atespace, actorID := "team-recon", "actor-recon"

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

createdActor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorID, Atespace: atespace}, ActorTemplateNamespace: ns, ActorTemplateName: "tmpl",
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -957,6 +975,11 @@ func TestReleaseActorOnDeadWorker_StateTransitions(t *testing.T) {
s := &WorkerPoolSyncer{persistence: persistence}

atespace, actorID := "team-status", "actor-status"

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

createdActor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorID, Atespace: atespace},
ActorTemplateNamespace: ns,
Expand Down
16 changes: 16 additions & 0 deletions cmd/ateapi/internal/controlapi/workflow_pause_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ func TestEnsurePausedFinalized_WorkerGone(t *testing.T) {
InProgressLocalSnapshotName: "local-snap-1",
},
}
if _, err := st.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}
if _, err := st.CreateActor(ctx, actor); err != nil {
t.Fatalf("CreateActor: %v", err)
}
Expand Down Expand Up @@ -111,6 +114,10 @@ func TestEnsurePausedFinalized_RecordsContentScope(t *testing.T) {
ctx := context.Background()
actorRef := resources.ActorRef{Atespace: "team-a", Name: "actor-1"}

if _, err := st.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

created, err := st.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: actorRef.Atespace, Name: actorRef.Name},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -239,6 +246,11 @@ func TestEnsureMarkedPausing_StateMatrix(t *testing.T) {
w := &ActorWorkflow{store: persistence}

actorRef := resources.ActorRef{Atespace: "team-a", Name: "id1"}

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: actorRef.Atespace, Name: actorRef.Name},
Status: &ateapipb.ActorStatus{State: seedState},
Expand Down Expand Up @@ -275,6 +287,10 @@ func TestEnsureAteletPaused_DanglingWorkerDoesNotRecordPhantomSnapshot(t *testin
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace() failed: %v", err)
}

actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{
Expand Down
9 changes: 9 additions & 0 deletions cmd/ateapi/internal/controlapi/workflow_resume_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ func TestAssignWorkerAttempt_ReleasesIneligibleStaleWorkerInBackground(t *testin
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "id1"},
Status: &ateapipb.ActorStatus{State: ateapipb.ActorState_ACTOR_STATE_SUSPENDED},
Expand Down Expand Up @@ -260,6 +263,9 @@ func TestAssignWorkerAttempt_RetryAfterConflictPicksFreshWorker(t *testing.T) {
t.Fatalf("UpdateWorker (concurrent claim): %v", err)
}

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "id1"},
Status: &ateapipb.ActorStatus{State: ateapipb.ActorState_ACTOR_STATE_SUSPENDED},
Expand Down Expand Up @@ -350,6 +356,9 @@ func seedAssignFixture(t *testing.T, ctx context.Context, persistence store.Inte
}); err != nil {
t.Fatalf("CreateWorker: %v", err)
}
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "id1"},
Status: &ateapipb.ActorStatus{State: ateapipb.ActorState_ACTOR_STATE_SUSPENDED},
Expand Down
36 changes: 36 additions & 0 deletions cmd/ateapi/internal/controlapi/workflow_suspend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ import (
func TestEnsureMarkedSuspending_SnapshotName(t *testing.T) {
ctx := context.Background()
persistence := newTestPersistence(t)
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{State: ateapipb.ActorState_ACTOR_STATE_RUNNING},
Expand Down Expand Up @@ -77,6 +80,9 @@ func TestEnsureMarkedSuspending_SnapshotName(t *testing.T) {
func TestEnsureMarkedSuspending_ReentryKeepsPersistedSnapshotLocation(t *testing.T) {
ctx := context.Background()
persistence := newTestPersistence(t)
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -175,6 +181,9 @@ func TestEnsureMarkedSuspending_StateMatrix(t *testing.T) {
w := &ActorWorkflow{store: persistence}

actorRef := resources.ActorRef{Atespace: "team-a", Name: "id1"}
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: actorRef.Atespace, Name: actorRef.Name},
Status: &ateapipb.ActorStatus{State: seedState},
Expand Down Expand Up @@ -262,6 +271,10 @@ func TestEnsureAteletSuspended_DanglingWorkerDoesNotRecordPhantomSnapshot(t *tes
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -316,6 +329,10 @@ func TestEnsureSuspendedFinalized_NoAssignment(t *testing.T) {
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

const snapshotName = "2026-01-01t00-00-00z-abc"
actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Expand Down Expand Up @@ -402,6 +419,10 @@ func TestEnsureSuspendedFinalized_ReleasesOnlyOwnWorker(t *testing.T) {
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "shared"},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -467,6 +488,10 @@ func TestEnsureSuspendedFinalized_SnapshotSourceActorVersion(t *testing.T) {
ctx := context.Background()
persistence := newTestPersistence(t)

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

const snapshotName = "2026-01-01t00-00-00z-abc"
_, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Expand Down Expand Up @@ -594,6 +619,9 @@ func TestEnsureMarkedSuspending_PausedScopeRejection(t *testing.T) {
w := &ActorWorkflow{store: persistence}

actorRef := resources.ActorRef{Atespace: "team-a", Name: "actor-1"}
if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}
actor, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: actorRef.Atespace, Name: actorRef.Name},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -628,6 +656,10 @@ func TestEnsurePausedSnapshotUploaded_Preconditions(t *testing.T) {
persistence := newTestPersistence(t)
w := &ActorWorkflow{store: persistence, dialer: newDanglingDialer()}

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

created, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{
Expand Down Expand Up @@ -657,6 +689,10 @@ func TestEnsurePausedSnapshotUploaded_Preconditions(t *testing.T) {
persistence := newTestPersistence(t)
w := &ActorWorkflow{store: persistence, dialer: newDanglingDialer()}

if _, err := persistence.CreateAtespace(ctx, &ateapipb.Atespace{Metadata: &ateapipb.ResourceMetadata{Name: "team-a"}}); err != nil {
t.Fatalf("CreateAtespace: %v", err)
}

created, err := persistence.CreateActor(ctx, &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Atespace: "team-a", Name: "actor-1"},
Status: &ateapipb.ActorStatus{
Expand Down
8 changes: 8 additions & 0 deletions cmd/ateapi/internal/controlapi/workflow_testutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ func newTestActorWorkflow(t *testing.T, st store.Interface, tmplNamespace, tmplN
// opts mutate the actor before it is stored.
func seedWorkflowActor(t *testing.T, ctx context.Context, st store.Interface, actorRef resources.ActorRef, tmplNamespace, tmplName string, actorState ateapipb.ActorState, opts ...func(*ateapipb.Actor)) {
t.Helper()

atespace := &ateapipb.Atespace{
Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Atespace},
}
if _, err := st.CreateAtespace(ctx, atespace); err != nil {
t.Fatalf("seed atespace: %v", err)
}

actor := &ateapipb.Actor{
Metadata: &ateapipb.ResourceMetadata{Name: actorRef.Name, Atespace: actorRef.Atespace},
Status: &ateapipb.ActorStatus{State: actorState},
Expand Down
8 changes: 0 additions & 8 deletions cmd/ateapi/internal/store/atepg/atepg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,6 @@ func (p *Persistence) GetAtespace(ctx context.Context, name string) (*ateapipb.A
return getAtespaceRow(ctx, p.pool, name)
}

func (p *Persistence) AtespaceExists(ctx context.Context, name string) (bool, error) {
var exists bool
if err := p.pool.QueryRow(ctx, `SELECT EXISTS(SELECT 1 FROM atespaces WHERE name = $1)`, name).Scan(&exists); err != nil {
return false, fmt.Errorf("checking atespace existence: %w", err)
}
return exists, nil
}

func (p *Persistence) ListAtespaces(ctx context.Context, opts store.ListOptions) (store.ListResponse[*ateapipb.Atespace], error) {
pageSize, pageTokenStr := opts.PageSize, opts.PageToken
token, err := decodePageToken(pageTokenStr, kindAtespace, "", 1)
Expand Down
Loading
Loading