[ refactor ] Algebra.Structures.KleeneAlgebra and Properties#3031
Open
jamesmckinna wants to merge 32 commits into
Open
[ refactor ] Algebra.Structures.KleeneAlgebra and Properties#3031jamesmckinna wants to merge 32 commits into
Algebra.Structures.KleeneAlgebra and Properties#3031jamesmckinna wants to merge 32 commits into
Conversation
… `Algebra.Definition.Star*Destructive`
…reinstating them
…reinstating them
Collaborator
Author
|
Oh, there I go again blundering into Suggested refactoring:
|
Algebra.Structures.KleeneAlgebraAlgebra.Structures.KleeneAlgebra and Properties
JacquesCarette
requested changes
Jun 27, 2026
JacquesCarette
left a comment
Collaborator
There was a problem hiding this comment.
It took me a frightfully long time to come around to the opinion that this change is the right one. So at the design level, this is an 'approve'. But there's a tiny nitpick before we can merge.
JacquesCarette
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes one possible approach to fixing #3003, building on #3030 (on which this blocks) by plumbing in the partial order structure (definable in a
CommutativeBand, but here only locally toIsKleeneAlgebra), and correcting the types of theAlgebra.Structures.IsKleeneAlgebra.star*fields to use this_≤_relation.TODO:
Algebra.Properties.KleeneAlgebra(a lot more work required!), but this is a substantive issue, echoing @Taneb's question about what axiomatisation (and hence which admissible properties) we actually want to have? UPDATED: now have added Conway C11 and C12, which weren't even in the original module! Not sure if we want/need C14n?