[ add ] Data.List.Base.foldMap and refactor#3026
Conversation
|
Thanks @JacquesCarette for continuing to comment on a Everything typechecks, but I have the feeling that the new definitions and properties are all still at present ... suboptimal. Certainly when trying to apply them to the intended refactorings of |
|
Everything typechecks, but I just have the feeling that the new definitions and properties are all still at present suboptimal... so maybe let this one lie for a bit before pursuing further? |
|
I've taken #3016 off the docket as being fixed by this PR, because there's currently no refactoring to allow eg |
JacquesCarette
left a comment
There was a problem hiding this comment.
Indeed, I would want to have all those proofs be properly equational. And some of the new reasoning combinators can be used to shorten some of the proofs you do have.
Fix the remaining (second and third) items in #3016 in line with my most recent comment on #2553
DONE:
foldMap-congruenttypechecksfoldr-congruentbecome an instance offoldMap-congruentNB. does not yet refactor/redefine definitions in
Data.Bool.ListActionetc. for the time being!