Add tactic-style ring solvers for rational and unnormalised rational numbers#2965
Open
dancewithheart wants to merge 11 commits intoagda:masterfrom
Open
Add tactic-style ring solvers for rational and unnormalised rational numbers#2965dancewithheart wants to merge 11 commits intoagda:masterfrom
dancewithheart wants to merge 11 commits intoagda:masterfrom
Conversation
…r Data.Rational.Unnormalised.Tactic.RingSolver
Author
|
Tested locally with: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the old rational ring-solver work to current stdlib.
The base solver modules already exist (
Data.Rational.SolverandData.Rational.Unnormalised.Solver); this PRData.Nat.Tactic.RingSolver,For normalized rationals the tactic wrapper targets propositional equality
≡, while for unnormalised rationals it targets rational equivalence ≃.
This PR continues/supersedes #2215, which I opened from my old GitHub account.
Fixes #1879.