Skip to content

[ add ] Algebra.Construct.Centre.X of an algebra X, following #2863#2885

Open
jamesmckinna wants to merge 17 commits intoagda:masterfrom
jamesmckinna:centres-bis
Open

[ add ] Algebra.Construct.Centre.X of an algebra X, following #2863#2885
jamesmckinna wants to merge 17 commits intoagda:masterfrom
jamesmckinna:centres-bis

Conversation

@jamesmckinna
Copy link
Collaborator

@jamesmckinna jamesmckinna commented Nov 19, 2025

This PR is a clean do-over of #2863 , avoiding any dependency/coupling on either #2872 or #2854 .

Issues:

NB. the hierarchy of IsXMonomorphism structures unfortunately (;-)/!?) goes against the grain of how these things are all built up successively here, so downstream we might think about refactoring that hierarchy, or else introducing more 'smart' constructors for such things.

@jamesmckinna jamesmckinna added this to the v2.4 milestone Nov 19, 2025
Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change needed: delete commented out code.

@jamesmckinna
Copy link
Collaborator Author

This is ready to go, so if someone is willing either to offer an additional review, or else support merging as-is, please do so!

@JacquesCarette
Copy link
Collaborator

I guess we need to explicitly ping people like @Taneb and @MatthewDaggitt since I've already done my part!

@jamesmckinna jamesmckinna requested review from gallais and removed request for Taneb February 18, 2026 12:15
@jamesmckinna
Copy link
Collaborator Author

So hopefully I've now dealt with the feedback above, EXCEPT:

  • trying to unpack isRingHomomorphism exposes that the exports of Ring fail to capture all the necessary nested records
  • that I'm not convinced that writing out all the sub-records makes sense (discuss?)
  • BUT that it might also be useful to explicitly export a bundled XMonomorphism from Z[ X ] to X (but we've never quite resolved to date where the unique morphisms arising from Algebra.Construct.Y should live?)

I suggest it's better to tackle these downstream!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants