[ fix ] Relation.Nullary.Decidable.Core names for combinators

[jamesmckinna]

Fixes #2842

Issues:

• lots of knock-on viscosity
• lots of other occurrences of -dec as a suffix which could/should be changed to ?

[gallais]

Thank you for that. Wondering whether there are a few more opportunities for consistent naming.

[jamesmckinna]

Thank you for that. Wondering whether there are a few more opportunities for consistent naming.

yes, hence the OP reference to "lots of other occurrences of -dec"... but I thought it better to handle those downstream.

I already encountered the need for some careful qualified importing in order to avoid name clashes, and I didn't want to get into deeper rabbit holes by widening the impact of this PR.

But happy to do so if reviewers agree, although Suggest we move such things downstream, as I think/worry it might open many more cans of worms? The ones you identify arise as direct consequences of this PR, but I fear the general pattern (and its violation) may be even more widespread...

[JacquesCarette]

Wow, I was surprised that you even attempted this as v2.4.

[JacquesCarette]

While I agree that there are quite a few more things that ought to be changed, I think that it is fine to do this kind of work incrementally. So what @gallais points out could form the basis of 2+ future PRs. Similarly with the wart that I point out.

[jamesmckinna]

While I agree that there are quite a few more things that ought to be changed, I think that it is fine to do this kind of work incrementally. So what @gallais points out could form the basis of 2+ future PRs. Similarly with the wart that I point out.

See also:

• the ∷-dec combinator, and friends, introduced in [ fix #698 ] Safe reflection module #799 / 'Gradual' decidable equality combinators #803 / n-ary decidable equality transformer #811
• ... others? (we should make a list on Use consistent names for Decidable combinators #2842 else as separate issues)

UPDATED this PR closes #2842 so lifted out the additional comments/examples to #2846. Merging now.

[jamesmckinna]

Ugh. Forgot to to fix the alignment in CHANGELOG.

[MatthewDaggitt]

That's okay, there's always a tidying up pass before release.