lib/fuse.c: fix memory leak in print_module_help()#6
Open
agabhin wants to merge 1 commit into
Open
Conversation
If the second fuse_opt_add_arg() fails, the function returns without calling fuse_opt_free_args(), leaking the argv allocated by the first successful call. Found by Facebook Infer (MEMORY_LEAK_C). Signed-off-by: Abhinav Agarwal <abhinavagarwal1996@gmail.com>
agabhin
force-pushed
the
fix-print-module-help-leak
branch
from
6e940b3 to
935aa13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix memory leak in
print_module_help()— if the secondfuse_opt_add_arg()fails, the function returns without callingfuse_opt_free_args(), leaking the argv allocated by the first successful call.Found by Facebook Infer (MEMORY_LEAK_C).