[#546] Reduce reflection in generated metadata and runtime code#547
Merged
Conversation
- Add initialValueFactory (Supplier) to ProcessedOption so generated code can restore Collection/Map fields without getDeclaredConstructor().newInstance() - GeneratedProcessedOption.restoreInitialValue() uses factory when available - CodeGenerator emits setInitialValueFactory(ArrayList::new) etc. for @OptionList, @OptionGroup, and @arguments fields - CommandContext.ContextFrame uses ProcessedOption.getFieldAccessor() for caching and restoring field values instead of raw Field reflection - Move internal command metadata providers into inner classes of AliasCommand, UnAliasCommand, ExportCommand for direct private field access without reflection - Annotation processor warns when private fields require reflective access, suggesting package-private visibility for reflection-free generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #546