Conversation
Haselnussbomber
requested changes
Apr 7, 2026
Collaborator
Haselnussbomber
left a comment
There was a problem hiding this comment.
Just briefly looked over it and have some comments. :)
wolfcomp
requested changes
Apr 8, 2026
Collaborator
wolfcomp
left a comment
There was a problem hiding this comment.
Just some observations when digging through the functions and based on previous places functions that has been scanned through.
Contributor
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.UI: 1UIModulePacketType: 4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if structs should exist within other structs or should be left outside. Deleted a few things I wasn't happy with. Please let me know if I've done something incorrectly so I know for next time and change anything you disagree with. TofuHelper seems to exclusively manage both sending and receiving of shared boards.