[C++] mark a generated function SBE_CONSTEXPR (#1055)#1083
Merged
vyazelenko merged 2 commits intoaeron-io:masterfrom Mar 28, 2026
Merged
[C++] mark a generated function SBE_CONSTEXPR (#1055)#1083vyazelenko merged 2 commits intoaeron-io:masterfrom
vyazelenko merged 2 commits intoaeron-io:masterfrom
Conversation
aschw
force-pushed
the
cpp-codegen-add-static-keywords
branch
from
d7e3e00 to
08db44f
Compare
vyazelenko
requested changes
Sep 4, 2025
| endif (NOT CMAKE_BUILD_TYPE) | ||
|
|
||
| if (NOT DEFINED CMAKE_CXX_STANDARD) | ||
| set(CMAKE_CXX_STANDARD 11) |
Contributor
There was a problem hiding this comment.
Why changed to C++ 14?
We can't accept this change, because there are existing customers on older C++ versions.
Contributor
Author
|
C++14 is required for more complex constsxpr function bodies (e.g. variable definition and array subscripting). |
aschw
force-pushed
the
cpp-codegen-add-static-keywords
branch
from
bec1cdd to
248eba4
Compare
vyazelenko
approved these changes
Mar 28, 2026
Contributor
vyazelenko
left a comment
vyazelenko
left a comment
There was a problem hiding this comment.
Looks good. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some missing SBE_CONSTEXPR to the C++ generated code.