feat: PieFed fake derives my_user in getSite + mark-all route#68
Merged
Conversation
- FakePiefedInstance's derived GET /api/alpha/site now includes my_user when seed.loggedInAs (typed myUserInfo/localUser builders, drift-safe), retiring the wire-level workaround consumers needed for logged-in boot - FakePiefedInstance derives POST /api/alpha/user/mark_all_as_read, mutating seed read-state like the v1 fake - matrix tests cover both across providers (getSite my_user with auth; markAllAsRead clears unread)
aeharding
changed the title
aeharding
force-pushed
the
test/piefed-fake-gaps
branch
from
July 5, 2026 23:35
b8f1166 to
82d060a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1 of the provider-matrix follow-ups (~/threadiverse-plan.md).
getSiteincludesmy_userwhenseed.loggedInAs— added typedmyUserInfo/localUserbuilders (drift-checked against the OpenAPI schema), so logged-in boot works without a wire override. Retires the documented workaround in Voyager'se2e/matrix/fixtures.ts.mark_all_as_readderived route, mutating seed read-state like the v1 fake — unblocks inbox mark-all in the matrix.getSite.my_user(with client auth, since lemmyv1 gates it on auth while piefed reads it from the site response) andmarkAllAsRead.Deferred from Wave 1:
max_depthin derived comment lists. Making the "N more replies" test seed-based would couple the fake to Voyager's client-sidedefaultCommentDepthmath and make it brittle — the honest wire-mock + canonical-payload assertion already there is the better tradeoff.433 tests, typecheck, lint, build clean.