Structure administrator

[Khl0r0]

Description

Summary

Add of a new type of manager with less rights on the structure (administrator) to include vice treasurer or president for example

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

• Add of a new model
• Modification of permissions

Additional Notes

Classification

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
• 🔧 Infra CI/CD (changes to configs of workflows)
• 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
• 😶‍🌫️ No impact for the end-users

Impact & Scope

• Core functionality changes
• Single module changes
• Multiple modules changes
• Database migrations required
• Other: ...

Testing

• 1. Tested this locally
• 2. Added/modified tests that pass the CI (or tested in a downstream fork)
• 3. Tested in a deployed pre-prod
• 0. Untestable (exceptionally), will be tested in prod directly

Documentation

• Updated the docs accordingly :
• " Docstrings
• # Inline comments
• No documentation needed

[Rotheem]

LGTM

[codecov]

Codecov Report

❌ Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (12b8866) to head (82b8de1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
app/core/mypayment/endpoints_mypayment.py	82.22%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         205      205           
  Lines       14821    14873   +52     
=======================================
+ Hits        12516    12560   +44     
- Misses       2305     2313    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Luhmos]

Good, would benefit from tests of more edge cases (e.g. last commit)

[Marc-Andrieu]

Haven't seen such a great PR description in a while!
Clean PR, very clear.

I don't get why you add structure admins as sellers everywhere (so that deleting an admin does not give them back their exact previous seller rights), instead of letting them access the endpoints to see history, manage sellers, etc.; but there might be a good reason for it!