Add unit tests and refactor date cleaning into function#13
Open
Add unit tests and refactor date cleaning into function#13
Conversation
hl3968-hue
approved these changes
Feb 25, 2026
Collaborator
hl3968-hue
left a comment
There was a problem hiding this comment.
Looks good! A few improvements in the latest commit:
- Extracted the plotting logic into a plot_ridership_recovery() function in utils.py so the 2 notebook stays clean and the function is reusable
- Added more tests — went from 2 to 6, now covering: original df not being mutated, already-sorted data, plot function returning a valid figure, and missing columns raising errors
3.Added comments in tests to clarify what each assertion is checking (e.g. the reset_index behavior)
hl3968-hue
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
How to run tests