Spend imminent overflow mana safely - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pwsh -File scripts/test-playerbot-gameplay.ps1 -MagicTraining -Focused -SkipBuild- passed 16 forecast, spell preference, overflow, arbitration, failure, continuation, and restart scenariospwsh -File scripts/test-playerbot-gameplay.ps1 -SpellUse -SpellCalibration -AdaptiveChallenge -Focused -SkipBuild- passed existing spell-use, calibration, and hunt-pressure regressionspwsh -File scripts/test-playerbot-gameplay.ps1 -FullNavigation -CorpseLoot -Focused -SkipBuild- passed navigation and corpse-loot regressionspwsh -File scripts/test-knight-spell-contract.ps1- passed audited Knight spell contractLimits
Magic-training scenarios use controlled Lua setup; they prove engine forecast arithmetic, arbitration, and selected normal casts, not long-running live frequency. Regeneration phase intentionally resets through condition serialization, so restart recomputes a fresh forecast.
The existing
-SpellTrainingroute fixture passed once on this branch but timed out on repeated runs after its spell-learning transaction failed and normal equipment/service behavior continued. Failure logs contained no selected magic-training candidate, so this appears unrelated to #98.Closes #98.