Calibrate Knight spell effects from observed casts - #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pwsh -File scripts/test-playerbot-gameplay.ps1 -SpellCalibration -Focused -SkipBuild -TimeoutSeconds 120- passed normal Light Healing, Haste, Whirlwind Throw, single/multi-target Berserk, confidence, ambiguity, eviction, and restart scenariospwsh -File scripts/test-playerbot-gameplay.ps1 -SpellUse -Focused -SkipBuild -TimeoutSeconds 120- passed existing healing, support, offense, reserve, and fallback behaviorpwsh -File scripts/test-playerbot-gameplay.ps1 -AdaptiveChallenge -Focused -SkipBuild -TimeoutSeconds 120- passed adaptive hunt recovery regressionpwsh -File scripts/test-knight-spell-contract.ps1- passed audited Knight spell contractLimits
Lua callback bounds are not exposed through the spell engine, so the calibration API manually mirrors the current Light Healing, Haste, Whirlwind Throw, and Berserk callbacks. Those envelopes must be reviewed with callback changes; historical 8.60 formula fidelity remains under #1. Profiles are memory-bounded and reset with the controller. Other-attacker and melee ambiguity use deterministic classifier coverage because the single-threaded normal speech cast cannot interleave those events reliably.
Closes #97.