fix: update ComboBox validate type for selection mode generic and null value#9742
Open
lixiaoyan wants to merge 2 commits intoadobe:mainfrom
Open
fix: update ComboBox validate type for selection mode generic and null value#9742lixiaoyan wants to merge 2 commits intoadobe:mainfrom
lixiaoyan wants to merge 2 commits intoadobe:mainfrom
Conversation
ComboBoxProps was using `Validation<ComboBoxValidationValue>` without passing the `M` generic, so the validate callback's `value` field was always typed as `Key` (single mode) even with `selectionMode="multiple"`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Since ComboBox supports allowsCustomValue, the validate function can be called with an empty selection in single mode. Update ValidationType to include null for single selection to match the runtime behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lixiaoyan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComboBoxPropswas usingValidation<ComboBoxValidationValue>without passing theM(selection mode) generic through. Fixed by changing toValidation<ComboBoxValidationValue<M>>so multi-select mode gets the correctKey[]type forvalue.ValidationType<'single'>resolved toKeybut the validate function can be called withnullwhen no item is selected (e.g. withallowsCustomValue). Updated toKey | nullto match the runtime behavior.Test plan
yarn check-typespasses with no new errorsComboBoxwithselectionMode="multiple"has correctly typedvaluefield (Key[]) in the validate callbackComboBoxvalidate callback correctly typesvalueasKey | null🤖 Generated with Claude Code